Giter VIP home page Giter VIP logo

Comments (1)

PowerKiKi avatar PowerKiKi commented on June 3, 2024

Getters must match ~^(get|is|has)[A-Z]~ and setters must match ~^set[A-Z]~. Because we need a way to differentiate things that should be exposed through the API and other methods that should not be.

Knowing that, I suggest the following usage, because the prefix is naturally convey that the value is a boolean and nothing else:

trait HasIsActive
{
    /**
     * @var bool
     *
     * @ORM\Column(type="boolean", options={"default" = 1})
     */
    private $isActive = true;

    /**
     * Set is active
     */
    public function setIsActive(bool $isActive): void
    {
        $this->isActive = $isActive;
    }

    /**
     * Get is active
     */
    public function isActive(): bool
    {
        return $this->isActive;
    }
}

which will generate something like:

type MyObject {
  """Is active"""
  isActive: Boolean!
}

input MyObjectInput {
  """Is active"""
  isActive: Boolean = true
}

Or this alternative, if you don't like is:

trait HasActive
{
    /**
     * @var bool
     *
     * @ORM\Column(type="boolean", options={"default" = 1})
     */
    private $active = true;

    /**
     * Set is active
     */
    public function setActive(bool $active): void
    {
        $this->active = $active;
    }

    /**
     * Get is active
     */
    public function getActive(): bool
    {
        return $this->active;
    }
}

which would end up as:

type MyObject {
  """Is active"""
  active: Boolean!
}

input MyObjectInput {
  """Is active"""
  active: Boolean = true
}

So yes, that means that this library forces you to name things a certain way. And there is no (easy?) way around it. It was built this way to allow to quickly expose an API for a huge project, without refactoring the existing codebase.

from graphql-doctrine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.