Hi, amazing library 🎉 I've a feature request for listing sortings

Implemented in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url=

Seems to have a bug... <div class="highlight highlight-source-graphql notranslate

More sorting orders about graphql-doctrine HOT 3 CLOSED

sambaptista commented on June 3, 2024

More sorting orders

from graphql-doctrine.

Comments (3)

PowerKiKi commented on June 3, 2024

Implemented in 46f4f16

from graphql-doctrine.

sambaptista commented on June 3, 2024

Seems to have a bug...

{
  bookings(filter:{}, 
    sorting:[{field:endDate, order:DESC, nullAsHighest:false}]) {
    items {
      id
      endDate
    }
  }
}

Returns

        {
          "id": "4012",
          "endDate": "2019-02-07T16:15:03+01:00"
        },
        {
          "id": "4000",
          "endDate": "2018-01-01T18:21:43+01:00"
        },
        {
          "id": "4001",
          "endDate": null
        },

And it's correct, but with nullAsHighest:true all results are reversed (= same as default ASC) :

        {
          "id": "4011",
          "endDate": null
        },
        {
          "id": "4000",
          "endDate": "2018-01-01T18:21:43+01:00" 
        },
        {
          "id": "4012",
          "endDate": "2019-02-07T16:15:03+01:00"
        }

Expectations is that endDate.DESC should return first 2019 (id 4012), then 2018 (id 4000) whatever nullAsHighest is true or false. When true, only the null values should display before the 2019.

Used here :
Ecodev/my-ichtus@683828a

from graphql-doctrine.

PowerKiKi commented on June 3, 2024

You should specify two sortings. One for the null values, and one for the "normal" sorting.

Fixed in Ecodev/my-ichtus@6e70748

So using ASC order will give you null values at the end:

{
  bookings(sorting: [
    {field: endDate, order: ASC, nullAsHighest: true},
    {field: endDate, order: ASC}
  ]) {
    items {
      id
      endDate
    }
  }
}

{
  "data": {
    "bookings": {
      "items": [
        {
          "id": "4000",
          "endDate": "2018-01-01T18:21:43+11:00"
        },
        {
          "id": "4001",
          "endDate": "2019-02-07T18:16:55+11:00"
        },
        {
          "id": "4012",
          "endDate": null
        }
      ]
    }
  }
}

And using DESC order will give you the null values at the beginning:

{
  bookings(sorting: [
    {field: endDate, order: DESC, nullAsHighest: true},
    {field: endDate, order: DESC}
  ]) {
    items {
      id
      endDate
    }
  }
}

{
  "data": {
    "bookings": {
      "items": [
        {
          "id": "4012",
          "endDate": null
        },
        {
          "id": "4001",
          "endDate": "2019-02-07T18:16:55+11:00"
        },
        {
          "id": "4000",
          "endDate": "2018-01-01T18:21:43+11:00"
        }
      ]
    }
  }
}