logback-encoder: Inconsistent usage of space character after comma about ecs-logging-java HOT 4 CLOSED

Sounds good to me, too. At least it's consistent now.

Btw, the reason there's a space after log.level is to ensure the message always starts at the same location, no matter how many characters the value of log.level has:

"log.level": "INFO","message":"foo"
"log.level":"DEBUG","message":"foo"

from ecs-logging-java.

@ChristianCiach and @eyalkoren Would you expect that there's a space after every comma or never a space after a comma? Or are you indifferent as long as it's consistent?

I also noticed that some key:value pairs have a space after the colon while some don't

I'd say the most readable variants are either

No space after colon and a space after the comma

{"key1":"value1", "key2":"value2"}

or a space after colon and a space after the comma

{"key1": "value1", "key2": "value2"}

But personally, I don't have a strong opinion and don't mind the inconsistency too much.

from ecs-logging-java.

I printed it both as is and as pretty string and I wouldn't be able to tell the difference until pointed out for me.
Currently it's without any space in both cases. It's easier because I don't have to care about last or not.
Since its such low importance, I'd be happy to invest as little as possible in that.

from ecs-logging-java.

Personally I would've preferred to always have a space after a comma, but consistency is way more important to me than my personal preferences. Thanks for "fixing" this!

from ecs-logging-java.