Giter VIP home page Giter VIP logo

Comments (3)

felixbarny avatar felixbarny commented on July 26, 2024 1

marker.getFieldName() and marker.getFieldValue() as key value pair in the output, not the name of the marker. Am I missing something?

The thing is that the getFieldName and getFieldValue methods are not part of the org.slf4j.Marker interface but are part of logstash-logback-encoder. But adding support for these markers does sound like a good idea. See also #49

from ecs-logging-java.

MitchelNijdam-Rockstars avatar MitchelNijdam-Rockstars commented on July 26, 2024

After thinking about it over the weekend, I realised that it makes sense that something called a "marker" is not more than a single value - as implemented.

However I still do wonder what the use is for the fieldName and fieldValue is when it gets ignored, especially as the official documentation says one should use it like my example.

from ecs-logging-java.

MitchelNijdam-Rockstars avatar MitchelNijdam-Rockstars commented on July 26, 2024

Ah indeed, I was looking at the specific implementations of Marker. I think my question is answered then, and #49 should be sufficient to capture my request.
Thanks!

from ecs-logging-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.