Giter VIP home page Giter VIP logo

wingpanel-indicator-datetime's Introduction

Wingpanel Date & Time Indicator

Packaging status Translation status

Screenshot

Building and Installation

You'll need the following dependencies:

  • gobject-introspection
  • libecal1.2-dev
  • libedataserver1.2-dev
  • libical-dev
  • libgranite-dev >= 6.0.0
  • libwingpanel-dev
  • meson
  • valac >= 0.40.3

Run meson to configure the build environment and then ninja to build

meson build --prefix=/usr
cd build
ninja

To install, use ninja install

sudo ninja install

wingpanel-indicator-datetime's People

Contributors

bagjunggyu avatar codygarver avatar colindemian avatar comradekingu avatar danirabbit avatar dartdeadia avatar davidmhewitt avatar elementarybot avatar fitojb avatar gerito1 avatar hugok79 avatar ihorhordiichuk avatar jaimie85 avatar jendamarek avatar johndumpling avatar josprachi avatar lenemter avatar marcin-serwin avatar marcuswichelmann avatar nathanbnm avatar norwayfun avatar p-bo avatar peteruithoven avatar queeup avatar ryonakano avatar tintou avatar tomiohl avatar weblate avatar welaq avatar yarons avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

wingpanel-indicator-datetime's Issues

current master (ab6db27) fails to build due to CMake error (?)

During compilation, I get the following cryptic error (full absolute paths to build directory shortened to "..." for easier reading):

cd .../src && /usr/bin/valac -C -b .../src -d .../src --pkg=wingpanel-2.0 --pkg=glib-2.0>=2.32 --pkg=granite --pkg=libecalendar-1.2 --pkg=libedataserver-1.2 --pkg=libical --pkg=libsoup-2.4 --target-glib=2.32 --vapidir=.../vapi --thread -g --save-temps .../src/Indicator.vala .../src/Widgets/PanelLabel.vala .../src/Widgets/calendar/Calendar.vala .../src/Widgets/calendar/CalendarModel.vala .../src/Widgets/calendar/CalendarView.vala .../src/Widgets/calendar/ControlHeader.vala .../src/Widgets/calendar/Util.vala .../src/Widgets/calendar/Grid.vala .../src/Widgets/calendar/GridDay.vala .../src/Widgets/calendar/Header.vala .../src/Widgets/calendar/WeekLabels.vala .../src/Services/TimeManager.vala .../src/Services/ClockSettings.vala .../src/Services/SettingsManager.vala .../src/config.vala .../src/.../vapi/posix-extension.vapi
warning: --save-temps has no effect when -C or --ccode is set
error: .../src/.../vapi/posix-extension.vapi not found
make[2]: *** [src/CMakeFiles/datetime.dir/build.make:125: src/datetime_valac.stamp] Error 1

It looks like the path to the "posix-extension.vapi" file contains the build directory path ("...") twice, which results in vala not being able to find the file.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Double-clicking day in calendar opens wrong date in Maya

See this reddit thread for reference:

https://www.reddit.com/r/elementaryos/comments/5gvxx0/bug_in_calendar_control_in_top_bar/

Double-clicking one of the dates in the calendar, it opens Maya with command line arguments in dd/mm/yyyy format, when Maya seems to be expecting mm/dd/yyyy format.

The dd/mm/yyyy format is hard-coded in Calendar.vala. Does Maya expect different formats depending on localization?

Launchpad Details: #LP1647908 James McManus - 2016-12-07 01:58:11 +0000

Can't see when I have an event

Compared to other datetime indicators, the integration of events is very bad. At least, the days where something is going to happen should be bold. Now we have to click all days to see if eventually there is already an event, which is very inconvenient.

Launchpad Details: #LP1653216 Olivier Vopat - 2016-12-30 10:10:29 +0000

Calendar scrolling lag

Months scrolling lags heavily after last update.
Moreover seems like the whole wingpanel freezes. I'm using System Load Indicator and it's stops for a while on calendar scroll.

I've got a PC that powerful enough:

  • Quad-Core Intel® Core™ i5-3570K CPU @ 3.40GHz
  • 12.0 GB memory

And it wasn't like this before update.
So it seems like a bug.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

ISO 8601 for date/time format

There used to be a custom-time-format available option in com.canonical.indicator.datetime, but this options seems to be gone

The only option I have is to switch between 12h and 24h clocks. I'm stuck with a date format that is alien to me (weekday, 3-letter month, day), when I'd much prefer to see dates in ISO 8601 format (yyyy-mm-dd hh:mm). This shouldn't be determined by my region (which uses days before months, so the current format is wrong anyway), but by some setting specific for dates.

Panel crashes when witching to May 2017

See above, also got the following error in the Console output:

RROR:/build/wingpanel-indicator-datetime-3BZi2M/wingpanel-indicator-datetime-2.0.1+r166+pkg10~ubuntu0.4.1/src/Widgets/calendar/Util.vala:44:util_date_range_construct: assertion failed: (first.compare (last) <= 0)

Launchpad Details: #LP1659661 Fabian Thoma - 2017-01-26 21:42:48 +0000

Week Numbers not styled properly

When "Show Date & Time" is toggled On in the Date & Time settings, it appears to me that the styling is a little off (lack of padding e.t.c).

This is on Elementary 0.4.1 Loki

screenshot from 2017-06-28 20 49 49

Wingpanel Crashes when clicking on the date

This happens -everytime- I click the date. I think it happened once I synced up the Calendar with my gmail account, but its been so long now I've honestly forgotten.

Launchpad Details: #LP1635766 KJ Lawrence - 2016-10-22 01:38:49 +0000

Current day blue highlight does not update properly in the calendar

When a system has been on over the span of two separate days, the indicator's calendar does not highlight the current day correctly. This is assuming that the day highlighted in blue is supposed to be the "current" day. The attached image shows the indicator in such a state, where the day is the 13th, but the 12th is still highlighted in blue.

Clicking the month above the calendar or moving to a different month seems to trigger an update and the highlight finally moves to the correct day.

Launchpad Details: #LP1623773 David Berg - 2016-09-15 04:09:05 +0000

Unable to add multiple time zones

With Freya it appears you can no longer add multiple time zones and is limited to just one. Click on the calendar/timestamp (upper middle) and click Time & Date Settings... (notice before clicking there is only one time listed). Now when on the Date & Time plug (side note: the menu also should probably be changed to reflect the inconsistency in name Time & Date Settings to Date & Time Settings...) there is no place to add another time zone.

Launchpad Details: #LP1369233 Eric Pritchett - 2014-09-14 09:28:31 +0000


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

licensing information incorrect in some source files

For Example (maya-calendar):

Running licensecheck on the maya-calendar sources reports that some of the files which include licensing information include the wrong FSF address.

 $ licensecheck -r . | awk -F ": " '{ print $2 }' | sort | uniq -c | sort -gr

    163 No copyright UNKNOWN
    101 UNKNOWN
     38 GPL (v3 or later)
      6 LGPL (v2 or later) (with incorrect FSF address)
      4 No copyright GENERATED FILE
      4 BSD (2 clause)
      3 No copyright GPL (v3 or later)
      2 LGPL (v2.1 or later)

The affected files are:

 $ licensecheck -r . | grep incorrect
  ./core/Backends/Backend.vala: LGPL (v2 or later) (with incorrect FSF address)
  ./core/Backends/BackendsManager.vala: LGPL (v2 or later) (with incorrect FSF address)
  ./core/Backends/LocalBackend.vala: LGPL (v2 or later) (with incorrect FSF address)
  ./core/Backends/PlacementWidget.vala: LGPL (v2 or later) (with incorrect FSF address)
  ./plugins/CalDAV/CalDAVBackend.vala: LGPL (v2 or later) (with incorrect FSF address)
  ./plugins/Google/GoogleBackend.vala: LGPL (v2 or later) (with incorrect FSF address)

Package checkers / linters (for example the compulsory fedora one - rpmlint) complain very verbosely about this.

Launchpad Details: #LP1653413 Fabio Valentini - 2017-01-01 11:16:13 +0000

Long event names break style

Some long event names break the style of the indicator making the settings button seem to go past the end of the popup
screenshot from 2017-11-22 22 43 17

Also really long words do not fall back to char wrapping which creates a weird appearance
screenshot from 2017-11-22 22 43 36

Localisation in date/time indicator wrong

I have installed elementary in English language, from a German location and selected a German keyboard layout. Even so, the time / calendar indicator displays the name of day on WingPanel, the day (1st row of popup), the month/year picker (2nd row) and the list of days (3rd) in German language instead of English.

Launchpad Details: #LP1474151 quassy - 2015-07-13 22:55:20 +0000


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Don't keep focus on different day in other months

When you open the indicator, it's focused on the current day. When you switch months, it explicitly re-focuses the matching day in the other months, which can get confusing because it looks like today is the day in the other month.

Instead, we should just leave the days unfocused when the user switches the month, or at the very most re-focus the current day on the current month only.

Shows "undef" text

I haven't test it yet but it is possible that the panel label and the today_button will show 'undef' as text.

in http://bazaar.launchpad.net/~wingpanel-devs/wingpanel-indicator-datetime/trunk/view/head:/src/Services/TimeManager.vala#L48

 public string format (string format) {
  if (current_time == null)
   return "undef";

  return current_time.format (format);
 }

in the following links you can see this is not catched.
This is not a text you want to show the user

http://bazaar.launchpad.net/~wingpanel-devs/wingpanel-indicator-datetime/trunk/view/head:/src/Widgets/PanelLabel.vala#L26
http://bazaar.launchpad.net/~wingpanel-devs/wingpanel-indicator-datetime/trunk/view/head:/src/Indicator.vala#L90

Launchpad Details: #LP1467253 kay van der Zander - 2015-06-21 12:53:28 +0000

Wingpanel time ignores Date & Time settings when Region is set to a 24 hour format region

Summary

I live in the UK and I set the system region and formats to United Kingdom (under English in the Language & Region settings). United Kingdom is defined as a 24 hour format but I'm used to AM/PM.

It seems that if you set Region (not Formats) in Language & Region to one that uses a 24 hour time format, for example United Kingdom or Australia under English or France under français, the time shown in Wingpanel changes to 24 hour format after logging in again, regardless of the time format set in Date & Time. It won't let me change it to AM/PM.

However, if you have the system set to a region that uses AM/PM (e.g. United States), you can freely change between AM/PM and 24h formats in the Date & Time settings.

Update: Upon further testing, time pickers seem to be partially affected by this as well. The input shows 24 hour time, but when the clock is clicked, it shows a AM/PM picker if the time format in Date & Time is set to AM/PM.

(I've also noticed that Pantheon's greeter seems to act strange with time formats, but that's a different issue and it's already been reported.)

Steps to reproduce

  1. Go to Language & Region in System Settings and set the Region to United Kingdom under English (or any other region that has 24 hour format by default, for example this bug also applies to France under "français").
  2. Log out and in again
  3. The time in Wingpanel appears in 24 hour format, regardless of what the time format is set to in Date & Time.
  4. Go to Date & Time in System Settings and try to change the time format. It won't change.

What is expected

Wingpanel time format only reflects the time format set in Date & Time, even when the region is changed.

What actually happens

Wingpanel time format is overridden by Region being set to a 24 hour format region and can't be changed in that state.

Missing space after comma following Day

The date display is now missing a space after the comma after the day abbreviation.

It does not look neat and spoils the otherwise pixel perfect spacing of the wingpanel.

E.g.

"Fri,Jun 9 11.40"

instead of

"Fri, Jun 9 11.40"

Regards,

John

project fails to compile with latest vala 0.38

This is hitting the same problem as elementary/calendar#143, where property names seem to get overloaded by accident now, and the names "first" and "last" have to be avoided.

(...)/build/src/Widgets/calendar/Util.c:59:2: error: redeclaration of enumerator 'UTIL_DATE_RANGE_LAST_PROPERTY'
  UTIL_DATE_RANGE_LAST_PROPERTY
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(...)/build/src/Widgets/calendar/Util.c:56:2: note: previous definition of 'UTIL_DATE_RANGE_LAST_PROPERTY' was here
  UTIL_DATE_RANGE_LAST_PROPERTY,
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [src/CMakeFiles/datetime.dir/build.make:274: src/CMakeFiles/datetime.dir/Widgets/calendar/Util.c.o] Error 1

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Jumps months as Date & Time Plug simply adds 31 days to move to the next month

It seems that the Date & Time Plug jumps months because it adds 31 days to the selected date/present date. This means selecting 31 January 2017 and clicking on the right arrow for next month, leads to 3 March 2017.

This should not be the ideal behavior as the next month is February 2017, not March 2017.

Launchpad Details: #LP1668175 Ruppal Singh - 2017-02-27 07:31:58 +0000

Feature request: Indicate days or dates with scheduled events

Currently, there is no way to tell from the wingpanel which dates have scheduled events. To tell that a date has a scheduled event, you will have to open the calendar app itself to know.

I imagine that as a cool feature, dates that have scheduled events can be 'boldened' so that with a quick glance, the user is able to at least have an idea of days with scheduled events.

So assuming you have scheduled events for the 20th and 27th, those dates can be 'boldened'; then upon double clicking on that date, the calendar app launches for you to view the details of the event (which is the way it currently behaves anyway).

This is just how I am imagining it. Perhaps a better and cleaner design approach can work.
The bottom line is that, I think it will be nice if the wingpanel calendar could indicate which dates have scheduled events
indicate-scheduled-event

Use same time format for greeter and indicator

The clock on the lock screen is displayed in 24 hour format even though I have system settings configured to display in 12 hour format. The clock on the desktop when logged in is correct.

Greeter should uses the time format as described by the locale.
The Indicator currently uses the format as set in the Date & Time Settings in Switchboard.
We should unify these two settings to apply to the locale so all applications can benefit from these settings.

Launchpad Details: #LP1048873 Anthony M - 2012-09-11 00:05:56 +0000

wingpanel-indicator-datetime looks deformed with fonts greater than 10pt

Here's some screenshots so you can understand me.

With fonts of 10pt. Looks nice.
wingpanel_default_font

Here's it with 12pt. Starting to look squished.
wingpanel_bigger_font

Now here's with fonts really big.
wingpanel_biggest_font

Any idea's an how to combat this?
I would imagine that we would want this indicator to look it's best even when fonts are really big.

Event showing up on incorrect days

I have a (repeated) event that's showing up on days it shouldn't.
It's an event that should appear every first Saturday of every month, at 13:00 - 17:00.

Some notes:

  • For some reason it appears on 3 - 31 mrt and 2 - 30 june. (It starts after the first Saturday)
  • Beside that Saturday it doesn't specify a time, as if it's a whole day event.
  • I have other (monthly) repeating events that are only shown on the appropriate days.
  • The event appears on the appropriate days in the Calendar app.
  • All events on the first Saturday on every month seems to create this issue.
  • Creating monthly repeating events on the first Friday or Sunday don't create this issue.

ical.as_ical_string of shown event:

BEGIN:VEVENT
UID:20180105T141524Z-6660-1000-1-0@xps
DTSTAMP:20180105T141524Z
SUMMARY:RC Leidsche Rijn
DTSTART;TZID=/freeassociation.sourceforge.net/Europe/Amsterdam:
 20180106T130024
DTEND;TZID=/freeassociation.sourceforge.net/Europe/Amsterdam:
 20180106T170024
LOCATION:Vrijetijdscentrum Voorn\, Akkrumerraklaan 131 utrecht
CREATED:20180105T141635Z
LAST-MODIFIED:20180306T193607Z
RRULE:FREQ=MONTHLY;BYDAY=1SA
X-EVOLUTION-CALDAV-HREF:
 /remote.php/dav/calendars/peteruithoven/extern/20180105T141524Z-6660-1000-
 1-0_xps-20180105T141635Z.ics
X-EVOLUTION-CALDAV-ETAG:"5a9e585da4c2a3a43673714fd1328d54"
END:VEVENT

I see the same ical string when I click on the Saterday it should show up.

Util.event_date_ranges gives a weird list of date ranges on the event:

  • 2018-01-06T00:00:00+0100 - 2018-01-06T00:00:00+0100
  • 2018-02-03T00:00:00+0100 - 2018-02-03T00:00:00+0100
  • 2018-03-03T00:00:00+0100 - 2018-03-03T00:00:00+0100
  • 2018-03-03T00:00:00+0100 - 2018-04-03T00:00:00+0200

The last date range suddenly covers a whole month, where the end date has another UTC time offset?

Wrong translation of month names is shown in ControlHeader in Juno

Due to an update of GLib (to 2.56 in Juno) the time format in ControlHeader.vala produces wrong month names in Czech (and maybe other languages as well). The time format that needs to be used is %OB instead of %B. (its for standalone months without a day number). See https://valadoc.org/glib-2.0/GLib.DateTime.format.html
I haven't tested if this format is backwards compatible. The same bug occures through many elementary apps (I tryed to report all the occurrences).

Current day in the popup should be more proeminent

As it stands right now, it looks like this, which makes it easy to miss which day is the current one, at a glance:
screenshot from 2018-08-20 13-19-43

I propose it has a subtle circle, using the theme's accent color, to emphasize the current day:
e

To reach that circle, one may use this CSS:

.accent {
    background-color: shade(@colorAccent, 1.55);
    color: shade(@colorAccent, 0.66);
}

EDIT: Made the mockup use a better color for current day that is at least WCAG AA compliant.

Deleted events in calendar still show in indicator.

  • Add some events to the current day using the indicator to open calendar.
  • Close the calendar and confirm events shown in popup.
  • Reopen the calendar and delete the events by editing them and pressing the Delete Event button.
  • Close the calendar and look at the popup. The events are still there. However, if they are clicked on to open the calendar, they are not in the calendar.

Restarting wingpanel causes the events to disappear from the popup.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.