Comments (4)
I think this rule of < 20 dependencies is counterproductive. I predicted people will just start depending on big meta-packages (like tidyverse) instead of smaller, more focused packages.
I suggest we do something like this (but not as hacky): many functions of the tidyverse are re-exported in many places and we can import them in a clever way to minimise dependencies. For example, tidyselect::any_of()
, tidyselect::ends_with()
, etc. are re-exported in dplyr so we can depend on dplyr only instead of tidyselect+dplyr.
I can submit a PR for this later this week.
from covidregionaldata.
This was changed in the development version of rlang: r-lib/rlang@aa587b0#diff-e4299ca7439da3d937d0a2b7b28e948378c040e1c337911055dbddf60af08e5c so it's probably just a mismatch between your local version and the version on GitHub Actions.
I don't think this was intended to be a re-export anyways so I removed it in d3c150b.
from covidregionaldata.
Hi Richard,
Firstly sorry for the lack of response here recently been very busy on another project and neglected everything else. Will get up to speed on the work you have been doing over the next few days and try and make some useful contributions.
For this issue, I agree limiting imports is a really good idea. My preferred solution would be yes to go with suggests and allow then a check for the package with a message about what is needed to be installed.
Auto-installing would make CRAN not happy I think and introducing code work arounnds might just make it harder to code things (though if possible could be useful).
from covidregionaldata.
If you can figure out why we're getting CMD check failures in reexports.Rd
that would be welcome too. My local build (when I build the documentation) makes a pointer to \item{rlang}{\code{\link[rlang:dot-data]{.data}}}
which fails; when I change it to \item{rlang}{\code{\link[rlang:tidyeval-data]{.data}}}
it works, but I am now having to do this manually after building the documentation.
from covidregionaldata.
Related Issues (20)
- Add tests for download_JSON and JSON_reader HOT 2
- Add memoise support for download_JSON HOT 1
- Update package logo with new datasets HOT 1
- Review depreciated features HOT 2
- HTTP error 502 when downloading Vietnam's json data HOT 6
- Upstream data changes break our regional code - Colombia, Cuba, India, United States HOT 11
- Switch to preferably pkgdown theme HOT 3
- Giant package logo in web docs HOT 6
- Vietnam handles province labels badly, possible str_conv issue
- We've also made a fix to `complete()` to ensure that it always works as expected with grouped data frames. One of the results of this fix is that you can no longer supply group variables to `complete()` (if you have a grouped data frame, `complete()` will work "within" each group so you shouldn't have access to them). See https://github.com/tidyverse/tidyr/pull/1300 for more details. HOT 2
- Warnings from countrycode
- Vietnam data timing out HOT 1
- Colombia failing download tests
- Italian COVID-19 Integrated Surveillance Data HOT 19
- Run country-specific tests when relevant files are modified HOT 2
- France has moved their data - this breaks slowstart
- France has moved their data - we need to use a new upstream source HOT 1
- covidregionaldata archived on CRAN HOT 3
- South Africa new reported cases around higher than Our World In Data/WHO HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from covidregionaldata.