Giter VIP home page Giter VIP logo

Comments (2)

github-actions avatar github-actions commented on July 20, 2024

This issue has been flagged as stale due to lack of activity

from covidregionaldata.

seabbs avatar seabbs commented on July 20, 2024

Thanks Hugo,

I agree it is nice to have country-specific changes being tested against the downloaded data, so thanks for adding this. The tagging files touched aspect of github actions was new to me. I would rather you didn't unilaterally merge PRs without review, especially when there is no detail of the work done in the PR. If easier we can talk about this via slack etc.

The original motivation for this was not to reduce computation but to deal with potential issues with downloading data. Having countries on a timer is there to check if the upstream source has changed.

The issue with the changes you have merged is now if a dataset is broken due to downloading issues (i.e maybe it can't be accessed) then all changes to shared methods etc will be flagged as failing CI. I would rather this was not the case as in the past this essentially made the whole system break and become completely useless. This was the original motivation for testing against downloaded snapshots and one of the primary motivators for having a complex CI system to begin with. Very open to discussion on this of course.

from covidregionaldata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.