Comments (2)
This issue has been flagged as stale due to lack of activity
from covidregionaldata.
Thanks Hugo,
I agree it is nice to have country-specific changes being tested against the downloaded data, so thanks for adding this. The tagging files touched aspect of github actions was new to me. I would rather you didn't unilaterally merge PRs without review, especially when there is no detail of the work done in the PR. If easier we can talk about this via slack etc.
The original motivation for this was not to reduce computation but to deal with potential issues with downloading data. Having countries on a timer is there to check if the upstream source has changed.
The issue with the changes you have merged is now if a dataset is broken due to downloading issues (i.e maybe it can't be accessed) then all changes to shared methods etc will be flagged as failing CI. I would rather this was not the case as in the past this essentially made the whole system break and become completely useless. This was the original motivation for testing against downloaded snapshots and one of the primary motivators for having a complex CI system to begin with. Very open to discussion on this of course.
from covidregionaldata.
Related Issues (20)
- Add tests for download_JSON and JSON_reader HOT 2
- Add memoise support for download_JSON HOT 1
- Update package logo with new datasets HOT 1
- Review depreciated features HOT 2
- HTTP error 502 when downloading Vietnam's json data HOT 6
- Upstream data changes break our regional code - Colombia, Cuba, India, United States HOT 11
- Check if some required packages could be made suggested HOT 4
- Switch to preferably pkgdown theme HOT 3
- Giant package logo in web docs HOT 6
- Vietnam handles province labels badly, possible str_conv issue
- We've also made a fix to `complete()` to ensure that it always works as expected with grouped data frames. One of the results of this fix is that you can no longer supply group variables to `complete()` (if you have a grouped data frame, `complete()` will work "within" each group so you shouldn't have access to them). See https://github.com/tidyverse/tidyr/pull/1300 for more details. HOT 2
- Warnings from countrycode
- Vietnam data timing out HOT 1
- Colombia failing download tests
- Italian COVID-19 Integrated Surveillance Data HOT 19
- France has moved their data - this breaks slowstart
- France has moved their data - we need to use a new upstream source HOT 1
- covidregionaldata archived on CRAN HOT 3
- South Africa new reported cases around higher than Our World In Data/WHO HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from covidregionaldata.