Giter VIP home page Giter VIP logo

We've also made a fix to `complete()` to ensure that it always works as expected with grouped data frames. One of the results of this fix is that you can no longer supply group variables to `complete()` (if you have a grouped data frame, `complete()` will work "within" each group so you shouldn't have access to them). See https://github.com/tidyverse/tidyr/pull/1300 for more details. about covidregionaldata HOT 2 CLOSED

seabbs avatar seabbs commented on July 20, 2024
We've also made a fix to `complete()` to ensure that it always works as expected with grouped data frames. One of the results of this fix is that you can no longer supply group variables to `complete()` (if you have a grouped data frame, `complete()` will work "within" each group so you shouldn't have access to them). See https://github.com/tidyverse/tidyr/pull/1300 for more details.

from covidregionaldata.

Comments (2)

RichardMN avatar RichardMN commented on July 20, 2024

I recommend we prioritize moving the fix for #447 into main ASAP, or just folding it into the various PRs. It breaks the R-CMD-Check so badly that these other PRs will fail even though the fixes themselves are ok.

from covidregionaldata.

seabbs avatar seabbs commented on July 20, 2024

Sounds like a good idea. I have merged the fix for this issue and made the default to not test region-level data (i.e the default is to just test within package functionality).

from covidregionaldata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.