Giter VIP home page Giter VIP logo

Comments (13)

AngusJohnson avatar AngusJohnson commented on May 23, 2024 2

I've just updated the Image32 repository and the fix above has been included.

from svgiconimagelist.

jfudickar avatar jfudickar commented on May 23, 2024 1

Hi Angus, I have not a real problem with it.
The delphi implementation is only a "nice to have" of my json2puml project.
Most of the people will work with the svg file directly.
But I wanted to mention it :-)

from svgiconimagelist.

jfudickar avatar jfudickar commented on May 23, 2024 1

Yes seems to fix it.
Nice.
And thanks!!!

from svgiconimagelist.

carloBarazzetta avatar carloBarazzetta commented on May 23, 2024

Please attach the SVG file...

from svgiconimagelist.

jfudickar avatar jfudickar commented on May 23, 2024

It must be attached somehow, because I dragged it in.
Try the right mouse click on the big image and save as.

from svgiconimagelist.

jfudickar avatar jfudickar commented on May 23, 2024

Should be here : https://user-images.githubusercontent.com/3485451/224549327-5f297927-e1ce-492b-94d3-dbeb6382c9a3.svg

from svgiconimagelist.

carloBarazzetta avatar carloBarazzetta commented on May 23, 2024

I've notice that the problems are in those 4 lines: adding an 'X' instead of three spaces shows the X with correct background color...
<text fill="#000000" filter="url(#bz2wwsoabm0qe0)" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="12" x="826.5" y="1801.0332">X</text> <text fill="#000000" filter="url(#bz2wwsoabm0qe1)" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="12" x="945.5" y="1801.0332">X</text> <text fill="#000000" filter="url(#bz2wwsoabm0qe2)" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="12" x="1032.5" y="1801.0332">X</text> <text fill="#000000" filter="url(#bz2wwsoabm0qe3)" font-family="sans-serif" font-size="14" lengthAdjust="spacing" textLength="12" x="1102.5" y="1801.0332">X</text>
Maybe an incorrect use of background text color for spaces, in Image32 SVG Library of Angus:
https://github.com/AngusJohnson/Image32

from svgiconimagelist.

jfudickar avatar jfudickar commented on May 23, 2024

Will you raise a ticket there?
I can't work with the X :-)

from svgiconimagelist.

AngusJohnson avatar AngusJohnson commented on May 23, 2024

Hi Jens. I can confirm there is a bug in Image32's SVG reader, but I can't see an easy fix.
While I've only had a quick look so far, the issue seems to be related to getting the correct bounds of the floodfill filter element.

from svgiconimagelist.

AngusJohnson avatar AngusJohnson commented on May 23, 2024

Here's a 'quick and dirty' solution ...

In TShapeElement.Draw() in Img32.SVG.Reader @ line ~2100

    //get special effects bounds
    if Assigned(clipPathEl) then
    begin
      ....
    end
    else if Assigned(maskEl) then
    begin
      ....
    end else
    begin
      clipRec := drawDat.bounds;
      // add this //////////////////
      if clipRec.IsEmpty and
        (drawDat.fontInfo.textLength > 0) and
        (self is TSubtextElement) then
      begin
        clipRec.Left := fParent.elRectWH.left.rawVal;
        clipRec.Bottom := fParent.elRectWH.top.rawVal;
        clipRec.Right := clipRec.Left + drawDat.fontInfo.textLength;
        clipRec.Top := clipRec.Bottom - drawDat.fontInfo.size;
      end;
      //////////////////////////////

from svgiconimagelist.

jfudickar avatar jfudickar commented on May 23, 2024

After upgrading to v4 the problem is back :-(

from svgiconimagelist.

jfudickar avatar jfudickar commented on May 23, 2024

Adding the line fixes it again !

from svgiconimagelist.

carloBarazzetta avatar carloBarazzetta commented on May 23, 2024

Oh, sorry, but I've aligned Image32 source code of @AngusJohnson retrieved from His Gitub repo, probably it was not updated...

from svgiconimagelist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.