Comments (2)
Sheeo
commented on August 19, 2024
Indeed coopGame, ladderGame and matchmakerGame have not yet implemented rate_game().
You're likely right that just making it a no-op is better. I'm leaning towards ditching the entire thing until there's a good reason for introducing an ABC for it.
from server.
Sheeo
commented on August 19, 2024
Then again, it's quite in the infancy of the design process at this point, it was introduced mostly to allow Game and GameConnection to share things without introducing a cyclic dependency.
from server.
Related Issues (20)
- Add localization key to notice messages
- Is an alternative account an issue, and how to deal with it if so. HOT 9
- Newly foed/friended players don't receive necessary game_info messages
- Unrank custom games after fixed time HOT 6
- Queue pop timer rate calculation is wrong
- Codecov report is broken
- Achievements are broken again HOT 1
- Consider using msgspec library for structured message serialization HOT 3
- Unrank games that are mutual draw HOT 7
- Better TMM map pool selection algorithm HOT 9
- Possibility to create own ban list HOT 2
- Possible to join TMM team when already in game/match launching state. HOT 3
- Error running RabbitMQ reconnect task
- Connection is closed if two login messages are sent to the same connection
- TMM queue pop timer can march to negative infinity HOT 3
- Clients get disconnected if they search for a queue that is inactive HOT 1
- Matchmaking balancing seems broken HOT 32
- Anope database is going away with IRC changes
- Server no longer uses `SINGLE_PLAYER` validity state
- Searches are sometimes left in the queue while players are doing other things HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from server.