farama-foundation / gym-examples Goto Github PK

First of all thanks for all this great work.

Would it be possible for you to add a license to this project?

The reason I ask, is because a standard copyright license could limit the possibility of academic publishing in some countries, like Denmark.

I should probably note that a copyleft license, can cause problems for some Ph.D. students (me included), which are hired by a company or an university that require employees to sign an invention clause. That said, it would still work better than a standard copyright license, I guess.

Thanks in advance.

Hi, I just followed this tutorial. It was really helpful to me.

I have a minor question about step() method.

The tutorial explains step() method returns 4-tuple (observation, reward, done, info). As far as I know, this convention is widely used in many environments.

However, in the code, step() method returns 5-tuple (observation, reward, terminated, False, info).

I read the code's history and found that the step() method initially returned 4-tuple and changed at the commit for Gym v0.26.

Can you tell me the if there is any background behind the change?

Thank you in advance.

Greetings,

I think this current tutorial is outdated especially considering now gym is replaced by gymnasium. I have simply just cloned this repository and exactly follow the tutorial in https://gymnasium.farama.org/tutorials/gymnasium_basics/environment_creation/ and I got the following error:

NamespaceNotFound: Namespace gym_examples not found. Have you installed the proper package for gym_examples?

Currently, there is no testing that the examples actually work as we claim they do
In addition, to improve code quality, it might be worth adding to the pre-commit pydocstyle, flake8, etc