faynopi / meowfetch Goto Github PK

goroutine 1 [running]:
meowfetch/configs.ParseConfig()
	/home/pm/Documents/meowfetch/configs/config.go:44 +0x4e
main.main()
	/home/pm/Documents/meowfetch/main.go:27 +0x2e

(Ignore my shell repeating my commands, I misstyped the zsh command version and created a second zsh instance in the process)

Love the idea! Looks super cute.

Two issues on macOS 12.3.1 (21E258):

1. When running make install in iTerm2 3.4.15, it crashes the shell window/tab.
2. If switching to vanilla Terminal, it appears to finish, but freezes without an exit code:

λ make

λ make install

[Process completed]

Happy to help troubleshoot 👌

Meowfetch only displaying SH as the system shell even when BASH, ZSH, FISH, etc are in use.

System Details -

EndeavourOS - Arch 5.19.2-arch1-1 Kernel
ZSH Shell (Do have Bash and FISH installed)

Steps to replicate -
Run meowfetch with the shell option added to widgets =
Produces the following for detected shell -

Run meowfetchusing env SHELL=<shellofchoice> meowfetch
Completes with detected shell as sh

From #4

9p4:
If there is no config found, fallback to a system-wide config in /etc/meow.conf

Itsnexn:
We do not produce configuration at /etc/meow.conf by default; instead, it is generated in $HOME/.meow.conf or $XDG CONFIG HOME/meowfetch/meow.conf. As a result, we don't require a backup for it.

At the parser function, we additionally check to see if a directory exists.

meowfetch/configs/config.go

As a result, I don't believe we need a fallback value for this function.

9p4:
There is an application for this. When calling meowfetch as part of a motd script, the script does not have environment variables initialized. Since the os.UserHomeDir and os.LookupEnv both use environment variables to get the location of the configuration, there ought to be a way for the system to fallback to a system-wide config.

https://pkg.go.dev/os#UserHomeDir

Itsnexn:

When calling meowfetch as part of a motd script, the script does not have environment variables initialized.

I don't understand what you mean by motd script.

Since the os.UserHomeDir and os.LookupEnv both use environment variables to get the location of the configuration, there ought to be a way for the system to fallback to a system-wide config.

there is no system-wide configuration. the program will generate config by itself if it does not exist.

meowfetch/configs/config.go

please open an issue about this problem and we could continue this conversation there.

I think the best approach would be to copy the config file using the makefile at the install time. we could remove the embed and then change the parser.