forestrymc / binnie Goto Github PK
View Code? Open in Web Editor NEWMinecraft addons for the Forestry mod. Extra Bees, Extra Trees, Genetics, and more.
Home Page: https://minecraft.curseforge.com/projects/binnies-mods
License: Other
Minecraft addons for the Forestry mod. Extra Bees, Extra Trees, Genetics, and more.
Home Page: https://minecraft.curseforge.com/projects/binnies-mods
License: Other
I think Binnie's mods were rarely used because they were difficult to understand.
Full JEI support should make using Binnie's mods much better.
It will also help find bugs, by making every recipe visible.
I would like to work on this part, it's a good test of JEI's API because the recipes are often complicated or strange.
In some cases I will want to simplify the way the recipes work while keeping their functions the same.
Genetics:
Extra Trees
Extra Bees
Botany:
Items stay visually in the cells.
Ex. Polymeriser genetic machine and DNA Sequence inside.
Bug from https://bitbucket.org/binnie567/binnie-mods/issues/383/coconut-trees
Original text:
the coconut trees in 1.7.10 only grow to 3 high and do not give any coconuts they need to be taller
Description: Exception ticking world
java.lang.NullPointerException: Exception ticking world
at net.minecraft.world.chunk.Chunk.func_177436_a(Chunk.java:540)
at net.minecraft.world.World.func_180501_a(World.java:335)
at net.minecraft.world.World.func_175656_a(World.java:417)
at forestry.arboriculture.tiles.TileLeaves.onBlockTick(TileLeaves.java:144)
at forestry.arboriculture.blocks.BlockForestryLeaves.func_180650_b(BlockForestryLeaves.java:93)
at net.minecraft.block.Block.func_180645_a(Block.java:494)
at net.minecraft.world.WorldServer.func_147456_g(WorldServer.java:472)
at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:219)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:709)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:384)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:624)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482)
at java.lang.Thread.run(Thread.java:745)
After some refactoring (soon), I'd like to split the mod into several.
I have to divide the project into several modules that are compiled separately? Inside the current project, of course.
I don't have enough experience.
Bug from https://bitbucket.org/binnie567/binnie-mods/issues/385/sequencer-progress-skipping-bug
Original text:
I wasn't sure what to name this issue, but the bug is pretty simple. Setup: Put 5 unanalysed sequences (Straight from the isolator) into the sequencer
Trigger: When the sequence in the middle slot has achieved some progress (e.g. 5% sequenced), shift click it (Sequence in middle slot).
Bug: The sequence will end up in your inventory, and the next sequence put into the slot will get the same progress percentage as the one you removed.
I'm not sure whether the sequence will have progressed this far, or whether it's only an issue with the displayed percentage. UPDATE: It's only a visual bug
Bug from https://bitbucket.org/binnie567/binnie-mods/issues/327/genepool-gui-rawdna-and-power-black-out
Original text:
The RawDNA and Power GUI bars go black when the genepool is in use. Hovering mouse cursor over the RawDNA tank renders both back to normal but as soon as you move off the RawDNA tank they go black again.
Rightclicking the machine with a filled bucket fills machine and leaves a full bucket. Need to check for other machines.
Bug from https://bitbucket.org/binnie567/binnie-mods/issues/267/compartment-dupe
Original text:
There is a dupe with Compartments (All types), where if someone is to place an item in the compartment, and stay looking in the GUI. Someone else is able to break the compartment, but the person in the GUI can take the item out, and the person who broke it will have the items inside. Thus duplicating items.
[21:28:37] [Server thread/INFO]: marcin212 lost connection: TranslatableComponent{key='disconnect.genericReason', args=[Internal Exception: io.netty.handler.codec.EncoderException: java.lang.NullPointerException], siblings=[], style=Style{hasParent=false, color=null, bold=null, italic=null, underlined=null, obfuscated=null, clickEvent=null, hoverEvent=null, insertion=null}}
Bug from https://bitbucket.org/binnie567/binnie-mods/issues/345/alcohol-recipes-and-crafting
Original text:
Brewery can be abused to create infinite wine/mash etc provided the yeast/grain/hops is put in first. None of these resources are consumed.
In all project's code. Need to wrap to localize method.
This is replaced by Field Kit.
Need to removed this item from mod?
[21:01:41] [Server thread/ERROR] [FML]: A TileEntity type binnie.core.machines.TileEntityMachine has throw an exception trying to write state. It will not persist. Report this to the mod author
java.lang.NullPointerException
at binnie.genetics.machine.LaboratoryMachine$ComponentGUIHolder.writeToNBT(LaboratoryMachine.java:88) ~[LaboratoryMachine$ComponentGUIHolder.class:?]
at binnie.core.machines.Machine.writeToNBT(Machine.java:230) ~[Machine.class:?]
at binnie.core.machines.TileEntityMachine.func_189515_b(TileEntityMachine.java:49) ~[TileEntityMachine.class:?]
at net.minecraft.world.chunk.storage.AnvilChunkLoader.func_75820_a(AnvilChunkLoader.java:393) [avd.class:?]
at net.minecraft.world.chunk.storage.AnvilChunkLoader.func_75816_a(AnvilChunkLoader.java:184) [avd.class:?]
at net.minecraft.world.gen.ChunkProviderServer.func_73242_b(ChunkProviderServer.java:203) [lv.class:?]
at net.minecraft.world.gen.ChunkProviderServer.func_186027_a(ChunkProviderServer.java:231) [lv.class:?]
at net.minecraft.world.WorldServer.func_73044_a(WorldServer.java:1015) [lw.class:?]
at net.minecraft.server.MinecraftServer.func_71267_a(MinecraftServer.java:366) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:647) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_102]
net.minecraft.util.ReportedException: Updating screen events
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1708) ~[bes.class:?]
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1056) ~[bes.class:?]
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:372) [bes.class:?]
at net.minecraft.client.main.Main.main(SourceFile:124) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_111]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_111]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_111]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_111]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
Caused by: java.lang.NullPointerException
at binnie.core.BinnieCore.handleSpeciesDiscovered(BinnieCore.java:249) ~[BinnieCore.class:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_2_BinnieCore_handleSpeciesDiscovered_SpeciesDiscovered.invoke(.dynamic) ~[?:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) ~[EventBus.class:?]
at forestry.core.genetics.BreedingTracker.registerSpecies(BreedingTracker.java:248) ~[BreedingTracker.class:?]
at forestry.core.inventory.ItemInventoryAlyzer.analyzeSpecimen(ItemInventoryAlyzer.java:124) ~[ItemInventoryAlyzer.class:?]
at forestry.core.inventory.ItemInventoryAlyzer.func_70299_a(ItemInventoryAlyzer.java:88) ~[ItemInventoryAlyzer.class:?]
at net.minecraft.inventory.Slot.func_75215_d(Slot.java:70) ~[adl.class:?]
at forestry.core.gui.slots.SlotForestry.func_75215_d(SlotForestry.java:55) ~[SlotForestry.class:?]
at net.minecraft.inventory.Container.func_184996_a(Container.java:281) ~[acl.class:?]
at forestry.core.gui.ContainerForestry.func_184996_a(ContainerForestry.java:81) ~[ContainerForestry.class:?]
at forestry.core.gui.ContainerItemInventory.func_184996_a(ContainerItemInventory.java:54) ~[ContainerItemInventory.class:?]
at net.minecraft.client.multiplayer.PlayerControllerMP.func_187098_a(PlayerControllerMP.java:551) ~[bnp.class:?]
at net.minecraft.client.gui.inventory.GuiContainer.func_184098_a(GuiContainer.java:632) ~[big.class:?]
at net.minecraft.client.gui.inventory.GuiContainer.func_146286_b(GuiContainer.java:598) ~[big.class:?]
at forestry.core.gui.GuiForestry.func_146286_b(GuiForestry.java:152) ~[GuiForestry.class:?]
at net.minecraft.client.gui.GuiScreen.func_146274_d(GuiScreen.java:554) ~[bho.class:?]
at net.minecraft.client.gui.GuiScreen.func_146269_k(GuiScreen.java:512) ~[bho.class:?]
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1695) ~[bes.class:?]
... 9 more
Count of mutators is not affected for result.
Ex. I have mutation with 100% chance (when I tested Jaded bee restriction) and big Alveary without mutators. Chance 100%. If I placed Mutator block in Alveary, chance changed to 15% (15.000001 see in console).
https://github.com/Chocohead/Binnie-Patcher/issues
We should make sure major the issues reported there are resolved in this version.
I think this can be supplemented by analogy with the effects of bees.
Wrong recipe.
To fix the compile/decompile errors, the old code that was causing issues, was unneeded or required porting has been commented out.
All TODO's may require implementing or just removing the method, deleting a line etc. The repo is still a bit of a mess after decompiling.
If you're asking why am I pushing this in it's current state - I've got a few people asking if they could help. I don't intend to impede the porting progress. Besides, with the academic year starting, my time has become a little more scarce.
A few of the ported fragments may require a bit of a rewrite, as I' actually learning MC's new model system and Forestry's new API, which in it self was not working fully (registering trees and such).
I also wanted to keep the functionalyty piece for piece, so some things are done in a very roundabout way and require refactoring.
As you can see, the mod is split into modules:
Each of the modules has its own submodules. I'll probably create milestones or project columns for each of them. As far as the porting order goes, I listed the above modules in complexity order (core/craftgui not included).
The repository after running the command:
gradlew setupDecompWorkspace idea should compile and launch MC. After planting a bunch of trees and waiting, MC should crash, most probably because of improper butterflies registering.
I would suggest disabling all modules and submodules and porting in order.
Known issues:
I think that's it for now. If I think of more, I'll update this list.
Thanks to @alucard87pl for translating.
At the minimum server assembly: Foresty + Binnie
https://pastebin.com/raw/dyd420vq
Sorry for bothering i18n stuff during early development.
Questions to ask:
Enchancement from https://bitbucket.org/binnie567/binnie-mods/issues/373/botany-vanilla-tree-saplings-can-be
Origin text:
Basically, Forestry is able to take unconverted vanilla tree saplings into its analyzer block and be able to scan them and turn them into converted forestry saplings. where as unconverted vanilla flowers can't go into said block. However converted botany flowers can go into the analyzer.
Honey Crystal useless, because not implementing any logic.
Are we working on both 1.10 and 1.11 now? Or actively developing 1.11 but only fixing crash bugs on 1.10?
This project is spaces, Forestry is tabs.
We should choose now if this project should stay spaces or become tabs.
I would like it to match Forestry, there are already mistakes where tabs and spaces are mixed.
I seem unable to pull enzymes out of incubators with BuildCraft pipes. Other types of resources work just fine, like liquid growth medium or bacteria, but Enzymes just stay in the Incubator inventory. Maybe because they are items and not fluids? Maybe there is a problem that causes an issue for items (transport pipes) but not fluids (fluid pipes). Hoppers work just fine too, and have no problem pulling Enzymes out, so the problem seems exclusive to pipes.
I try "gradle build" but an error occurs.
Gradle still compiles Binnie.jar into build/libs before planting.
If I wanted to start minecraft with it, the game crash at startup.
The crash log:crash-2017-04-13_12.53.50-client.txt
If module Lepidopterology is disabled, shaped recipe for item Genetics.analyst
invoke crash, because Mods.Forestry.item("flutterlyzer")
return null.
> [19:54:31] [Netty Epoll Server IO #2/ERROR] [FML]: NetworkDispatcher exception
io.netty.handler.codec.EncoderException: java.lang.NullPointerException
at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:125) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:651) ~[minecraft_server.1.11.2.jar:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.write(NetworkDispatcher.java:543) ~[NetworkDispatcher.class:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:706) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:741) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:895) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:240) ~[minecraft_server.1.11.2.jar:?]
at net.minecraft.network.NetworkManager$4.run(NetworkManager.java:247) [er$4.class:?]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380) [minecraft_server.1.11.2.jar:?]
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:268) [minecraft_server.1.11.2.jar:?]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116) [minecraft_server.1.11.2.jar:?]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_102]
Caused by: java.lang.NullPointerException
> [19:54:31] [Netty Epoll Server IO #3/ERROR] [FML]: NetworkDispatcher exception
io.netty.handler.codec.EncoderException: java.lang.NullPointerException
at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:125) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:651) ~[minecraft_server.1.11.2.jar:?]
at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.write(NetworkDispatcher.java:543) ~[NetworkDispatcher.class:?]
at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:658) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:716) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:706) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:741) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:895) ~[minecraft_server.1.11.2.jar:?]
at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:240) ~[minecraft_server.1.11.2.jar:?]
at net.minecraft.network.NetworkManager$4.run(NetworkManager.java:247) [er$4.class:?]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:380) [minecraft_server.1.11.2.jar:?]
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:268) [minecraft_server.1.11.2.jar:?]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116) [minecraft_server.1.11.2.jar:?]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_102]
Caused by: java.lang.NullPointerException
Please add Lumbermill support for wood from other mods (TwilightForest, LOTR, Highlands, BoP etc.) or Minetweaker/Crafttweaker (Modtweaker) support.
https://github.com/jaredlll08/CraftTweaker/issues/239
jaredlll08/ModTweaker#496
I'm playing Infinity Evolved: Skyblock v.1.2.0; Genetics version 2.0-pre14; Forestry version 4.2.15.63
I've been trying to add "Species: Mystical" to my gene bank with no success. Issue most likely is caused by the fact that there are 2 different "Mystical" bees - regular one that I got from Botania's Hiveacynth flower (colored orange) and the one you get from crossbreeding Noble and Monastic bees (colored yellow).
I've been trying to add the orange one (from Botania flower).
I tested the lastest code and got this crash. (self compiled)
https://gist.github.com/Dream-Master/2296001641b719e20e6dcd00c28c7f68#file-binnie-crash
Version before the last commit works fine. Did Foresty updates for 1.7.10?
using forestry_1.7.10-4.2.16.64.jar and forge 1614
GUI:
Mutator in Alvery accepts any item, although only Soul Sand, Ender Pearl or Eye of Ender.
Is the plan to separate all 4 mods from another ?
Add Marble bees maybe?
The logic of generation is taken from Rocky hive.
I've got an ender bee from a villager, and I ran it throught my Escritorie to get her mutations. I've got the Jaded bee, but when I tryed to look up for her in the database, my game crashed.
Here is the crash report
The same issue as #56
Need add validate logic for Inoculator.TANK_VEKTOR
(VECTOR :) )
https://github.com/ForestryMC/Binnie/blob/master-MC1.11.2/src/main/java/binnie/genetics/machine/inoculator/InoculatorLogic.java#L80
The missing resources for domain botany are:
[13:47:15] [Client thread/ERROR] [TEXTURE ERRORS]: textures/items/tools/trowelWood.png
[13:47:15] [Client thread/ERROR] [TEXTURE ERRORS]: textures/items/tools/trowelDiamond.png
[13:47:15] [Client thread/ERROR] [TEXTURE ERRORS]: textures/items/tools/trowelIron.png
[13:47:15] [Client thread/ERROR] [TEXTURE ERRORS]: textures/items/tools/trowelGold.png
[13:47:15] [Client thread/ERROR] [TEXTURE ERRORS]: textures/items/tools/trowelStone.png
Need to add this.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.