Comments (1)
I have added a new useHandlerRef
hook to memoize event handlers passed from props and applied it across all components where I was ignoring the deps array. Tested it in the flyout for now to make sure it works and will have to test it across all components that had a similar problem too.
Here is a code snippet if you need a temp workaround:
import React from "react";
import useIsomorphicLayoutEffect from "./useIsomorphicLayoutEffect";
const useHandlerRef = <T>(cb: T): React.RefObject<T> => {
const ref = React.useRef(cb);
useIsomorphicLayoutEffect(() => {
ref.current = cb;
});
return ref;
};
export default useHandlerRef;
const { onOpen } = props;
const onOpenRef = useHandlerRef(onOpen);
React.useEffect(() => {
onOpenRef.current?.();
}, [onOpenRef])
from reshaped.
Related Issues (20)
- [FEATURE]: Modal customizable container
- Export Theme Definition types on V3 HOT 4
- "unlock" icon broken HOT 1
- useScrollLock throwing document is not defined HOT 1
- `useScrollLock`breaks SSR HOT 1
- TypeError: Failed to load plugin 'jsx-a11y' declared in '.eslintrc.json' HOT 2
- Tests on PinField sometimes fail (source code) HOT 10
- Is the Toast color 'warning' missing? HOT 3
- DropdownMenu Flyout position changes based on mousedown duration HOT 3
- How to set the default "rem" unit when generating the theme? HOT 7
- Tailwind overrides the reset styles applied by Reshaped on the html element starting from `[email protected]` HOT 9
- borderRadius is missing in tailwind HOT 1
- Preventing default and stopping propogation HOT 2
- onBeforeClose hook for Overlay HOT 4
- [Feature Request] OverlayProvider HOT 2
- [Feature] PopoverContent offsetX, offsetY
- [BUG] Switch Label is not disabled.
- [Bug] Controlled TabList animation jumps
- [BUG] "mod" combinations from useHotkeys not working across different OS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reshaped.