Comments (3)
The button has the correct location on mousedown
, just not on mouseup
/click
, when (I presume) the function that shows the flyout is being called and the location is currently being queried.
Could the correct location not simply be saved upon mousedown
in some local state, and then used when the Flyout is being shown?
Otherwise the approach from the video seems decent, at least as a temporary fix, but at the same time this doesn't seem like an "urgent" issue that needs a temporary fix.
from reshaped.
Fixed it, I think the lazy part of me was speaking before since all bounds calculations were happening outside the component 😅
Now I'm saving the bounds on mousedown for cases when user might click the trigger and using the old way as a fallback.
Merging it in a bit, going to be officially announced in 3.2 but will appear in one of the upcoming patch releases as well
Screen.Recording.2024-08-15.at.00.03.32.mov
from reshaped.
Yes, I can confirm this is happening because of the button scaling.
It seems like the most straightforward way to fix the issue is to temporary drop the transition from the trigger when opening a dropdown. Main tradeoff is that it might not work for all types of transitions (e.g. might be noticeable in case it's used with custom long transition), however it would mean the position is calculated correctly.
Other approach I thought about is to calculate the bounds differently (with offsetTop/Left resolving for example), but that would mean positioning will stop respecting any transforms at all, unless those are calculated manually as well.
An example of the 1st approach, wdyt?
Screen.Recording.2024-08-14.at.00.55.09.mov
from reshaped.
Related Issues (20)
- Flyout onOpen handler is broken HOT 1
- [FEATURE]: Modal customizable container
- Export Theme Definition types on V3 HOT 4
- "unlock" icon broken HOT 1
- useScrollLock throwing document is not defined HOT 1
- `useScrollLock`breaks SSR HOT 1
- TypeError: Failed to load plugin 'jsx-a11y' declared in '.eslintrc.json' HOT 2
- Tests on PinField sometimes fail (source code) HOT 10
- Is the Toast color 'warning' missing? HOT 3
- How to set the default "rem" unit when generating the theme? HOT 7
- Tailwind overrides the reset styles applied by Reshaped on the html element starting from `[email protected]` HOT 9
- borderRadius is missing in tailwind HOT 1
- Preventing default and stopping propogation HOT 2
- onBeforeClose hook for Overlay HOT 4
- [Feature Request] OverlayProvider HOT 2
- [Feature] PopoverContent offsetX, offsetY
- [BUG] Switch Label is not disabled.
- [Bug] Controlled TabList animation jumps
- [BUG] "mod" combinations from useHotkeys not working across different OS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reshaped.