Giter VIP home page Giter VIP logo

Comments (9)

blvdmitry avatar blvdmitry commented on August 29, 2024 1

Are you using a custom theme there? You might need to regenerate it again to make sure rems are calculated based on 16px and not 14

from reshaped.

blvdmitry avatar blvdmitry commented on August 29, 2024

Let me think about it, the change in 3.0.3 was intentional to make sure custom product overrides take priority over the reshaped defaults but I will look into move some of the styles out of the rs.reset layer

from reshaped.

blvdmitry avatar blvdmitry commented on August 29, 2024

Actually, looking at the changes I have ready for the next patch, I have just moved out the font styles to the body and aligned the html font-size with the default browser one (also used in tailwind). Let me publish these changes and see if this helps in your case too.

I think this is also a good idea to start publishing more canary releases instead of patches.

from reshaped.

blvdmitry avatar blvdmitry commented on August 29, 2024

You can try it in 3.2.0-canary.0

from reshaped.

its-monotype avatar its-monotype commented on August 29, 2024

Thank you, it’s working correctly now. However, all the text variants appear larger than they were before.

from reshaped.

its-monotype avatar its-monotype commented on August 29, 2024

body-3 is now 16, body-2 ≈ 18, and body-1 ≈ 20 px. I think the body should range from 14-18 and a default of 16 px instead of 14 px is more common

from reshaped.

its-monotype avatar its-monotype commented on August 29, 2024

Yes, I’m using a custom theme. Thanks for pointing that out! I’ve rebuilt it, and everything’s working perfectly now.

from reshaped.

its-monotype avatar its-monotype commented on August 29, 2024

Now, even these tokens/values for each size look more rounded and clean. For example, instead of 4.571428571428571rem, it's now 4rem thanks to the use of 100%. Appreciate the improvements! 😀

from reshaped.

blvdmitry avatar blvdmitry commented on August 29, 2024

kudos to @randalmaia for opening #299 😅

from reshaped.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.