[bug] Creating Worlds in parallel can result in worlds with duplicate Ids about arch HOT 3 CLOSED

Well thats right, the world itself is not threadsafe, neither their creation or destruction.

That's fair lol

It's not really a problem in my app, it's just an issue in the Unit Tests themselves.

For now you could also just wrap the destruction and creation of worlds in locks to prevent this happening ^^

I did give that a try, and I'm admittedly not super familiar with C#'s threading practices so maybe I did it wrong, but I ran into some weirdness where the problem persisted.

I would have expected this to work:

// Helper file
public class WorldCreateHelper
{
    private readonly object myLock = new();

    public World ParallelSafeCreate()
    {
        lock(myLock)
        {
            return World.Create();
        }
    }
}

// Test file
public class SomeTests : IClassFixture<WorldCreateHelper>
{
    public SomeTests(WorldCreateHelper helper)
    {
        var world = helper.ParallelSafeCreate();
        // ...
    }

    // ...
}

But it didn't work...

¯\(ツ)/¯

I'm guessing it has to do with how xUnit was handling my helper fixture that wrapped around World.Create(), since the lock(object) documentation seems pretty straightforward.

To be fair, I don't really expect the [Collection] solution to be much a problem. it'll run tests where I need a World instance sequentially, but they're unit tests so I don't really expect to see much of a performance problem because they're not in parallel.

from arch.

Well thats right, the world itself is not threadsafe, neither their creation or destruction.
Never thought that this would become a issue. However this should be easy to fix. For now you could also just wrap the destruction and creation of worlds in locks to prevent this happening ^^

from arch.

Thats weird, normally this should work. Unfortunately i dont have that much threading experience either.
I assume that xUnit behaves way different. NUnit does mostly run them in sequence which is quite nice, at least for archs usecase ^^

from arch.