Giter VIP home page Giter VIP logo

Comments (14)

kltm avatar kltm commented on June 17, 2024

Ah yes, here's the other one. Let's talk when you're back on making sure we're on the same page with geneontology/minerva#448 .

from web-gocam.

ValWood avatar ValWood commented on June 17, 2024

Whre is the GO-CAM browser. site?

from web-gocam.

pgaudet avatar pgaudet commented on June 17, 2024

GO-CAM browser site [edited to correct perma-url -kltm]

from web-gocam.

kltm avatar kltm commented on June 17, 2024

@dustine32 has a possibly easy upfront fix with geneontology/pipeline#302. Testing now.

from web-gocam.

kltm avatar kltm commented on June 17, 2024

@pgaudet We may wrap this before even starting up. With the fix that @dustine32 has, http://geneontology.org/go-cam is now displaying 217 models and is quite snappy. Is this a sufficient fix for now?

from web-gocam.

ValWood avatar ValWood commented on June 17, 2024

Cool, I had totally forgotten about this.
Note that the link to the models from the "Browse models" tab is broken.

http://noctua.geneontology.org/editor/graph/gomodel:5745387b00001516

from web-gocam.

pgaudet avatar pgaudet commented on June 17, 2024

Can you explain what this is doing ?

217 models seem a bit modest to me - is that all the connected models we have?

  • I would expect this one to be in: gomodel:6246724f00001921
    It does show in Alliance: https://www.alliancegenome.org/gene/HGNC:20749
    but when I search for gene name in the GO-CAM browser (ZDHHC20)I get 0 results.

  • Also, I would expect gomodel:60ad85f700000058 NOT to be in; there some connected activities, but these are binding, and especially, there are many unconnected activities. Interestingly, this one is NOT in the mouse Alliance Atf2 page: https://www.alliancegenome.org/gene/MGI:109349

Are we using different rules than Alliance?

Thanks, Pascale

from web-gocam.

pgaudet avatar pgaudet commented on June 17, 2024

@pmasson55 estimates that about 100 Swiss-Prot models might be missing

from web-gocam.

ValWood avatar ValWood commented on June 17, 2024

I thought it was low. I tried to browse by species. "elegans" gave 2 models.

from web-gocam.

dustine32 avatar dustine32 commented on June 17, 2024

@pgaudet In general, it's querying all models containing a chain of at least two consecutive causal relations ("causally upstream of or within" RO:0002418 or descendants) connecting MF nodes. The actual query is here.

  • For gomodel:6246724f00001921 ZDHHC20-ZDHHC9 Palmitoyltransferase activity of Sars-Cov-2 S protein (Human-Sars-Cov-2), correct, this should be included in the GO-CAM browser site but for some reason is not picked up. And oddly it is showing up in the "by gene" query used by the Alliance gene page.
  • For gomodel:60ad85f700000058 Atf2 mouse, I can see why this model is picked up by the causal query:
    image
    It's kind of hard to see what the edges here are but they are "causally upstream of", and this chain of at least two consecutive causal relations between MFs is all that the query requires. Though, again, I agree that it's strange this model is not displayed on the Alliance gene page for Atf2 Mmus.

The query to retrieve models "by gene" for the Alliance site should be very similar to the "all causal models" query used for the GO-CAM browser site, but your examples here show that there is some difference that needs to be fixed. I'll make a ticket in the api-gorest-2021 repo to debug this. @pgaudet Thanks for the examples!

from web-gocam.

pgaudet avatar pgaudet commented on June 17, 2024

Thanks for the detailed reply @dustine32 !

from web-gocam.

kltm avatar kltm commented on June 17, 2024

@dustine32 I wanted to follow up on this a little and make this is current. Looking at our current script, we have:

wget http://localhost:8888/models?causalmf=2 -O gocam-models.json'

that is generating the json that gets put into the release. This then gets propagated out (automatically) to the API now defined by https://github.com/geneontology/api-gorest-2023, correct? While we have a more expansive version of this with tagging models in metadata, this first pass is done, correct?

from web-gocam.

dustine32 avatar dustine32 commented on June 17, 2024

@kltm Oh right, I believe this ticket is done.

And actually, this GO-CAM site pulls these JSONs directly from S3 rather than using a GO-CAM API passthrough:

let url = "https://go-public.s3.amazonaws.com/files/gocam-models.json"

from web-gocam.

kltm avatar kltm commented on June 17, 2024

@dustine32 yes, right you are; pushed on this bonus release pipeline: https://github.com/geneontology/pipeline/blob/f068cce4a3c1b84869e2f4cf501ac5b6c57e2e52/Jenkinsfile#L509

from web-gocam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.