Giter VIP home page Giter VIP logo

Comments (6)

k8scommander avatar k8scommander commented on September 27, 2024 3

Trying to reproduce it, for this part:

        err := ctx.ShouldBindJSON(&body)
        fmt.Println("end bind, err", err.Error())

if err == nil, printing err.Error() will produce an exception

For the second part:
s, _ := ioutil.ReadAll(ctx.Request.Body)
reading the request body will prevent you from binding at as it's already been read.

from gin.

JimChenWYU avatar JimChenWYU commented on September 27, 2024

image

There is an extra space.

from gin.

rcarrion2 avatar rcarrion2 commented on September 27, 2024

I have the same problem. I had to downgrade to 1.9.1.

from gin.

blkcor avatar blkcor commented on September 27, 2024

Trying to reproduce it, for this part:

        err := ctx.ShouldBindJSON(&body)
        fmt.Println("end bind, err", err.Error())

if err == nil, printing err.Error() will produce an exception

For the second part: s, _ := ioutil.ReadAll(ctx.Request.Body) reading the request body will prevent you from binding at as it's already been read.

Yes, that is.I think there is no bug actually

from gin.

RedCrazyGhost avatar RedCrazyGhost commented on September 27, 2024

@victor-gapeev There may be some logical problems with the code you write, and request.go explains Body io.ReadCloser and has a rudimentary understanding of its use

https://github.com/golang/go/blob/fc9f02c7aec81bcfcc95434d2529e0bb0bc03d66/src/net/http/request.go#L174-L196

@rcarrion2 @victor-gapeev If you need to use the data in the Body repeatedly, you can use methods that support caching the Body

Methods:

  • ctx.ShouldBindBodyWithJSON(&body)
  • ctx.ShouldBindBodyWithXML(&body)
  • ctx.ShouldBindBodyWithYAML(&body)
  • ctx.ShouldBindBodyWithTOML(&body)

gin/context.go

Lines 777 to 817 in 3cb3067

func (c *Context) ShouldBindBodyWith(obj any, bb binding.BindingBody) (err error) {
var body []byte
if cb, ok := c.Get(BodyBytesKey); ok {
if cbb, ok := cb.([]byte); ok {
body = cbb
}
}
if body == nil {
body, err = io.ReadAll(c.Request.Body)
if err != nil {
return err
}
c.Set(BodyBytesKey, body)
}
return bb.BindBody(body, obj)
}
// ShouldBindBodyWithJSON is a shortcut for c.ShouldBindBodyWith(obj, binding.JSON).
func (c *Context) ShouldBindBodyWithJSON(obj any) error {
return c.ShouldBindBodyWith(obj, binding.JSON)
}
// ShouldBindBodyWithXML is a shortcut for c.ShouldBindBodyWith(obj, binding.XML).
func (c *Context) ShouldBindBodyWithXML(obj any) error {
return c.ShouldBindBodyWith(obj, binding.XML)
}
// ShouldBindBodyWithYAML is a shortcut for c.ShouldBindBodyWith(obj, binding.YAML).
func (c *Context) ShouldBindBodyWithYAML(obj any) error {
return c.ShouldBindBodyWith(obj, binding.YAML)
}
// ShouldBindBodyWithTOML is a shortcut for c.ShouldBindBodyWith(obj, binding.TOML).
func (c *Context) ShouldBindBodyWithTOML(obj any) error {
return c.ShouldBindBodyWith(obj, binding.TOML)
}
// ShouldBindBodyWithJSON is a shortcut for c.ShouldBindBodyWith(obj, binding.JSON).
func (c *Context) ShouldBindBodyWithPlain(obj any) error {
return c.ShouldBindBodyWith(obj, binding.Plain)
}

from gin.

HHC26 avatar HHC26 commented on September 27, 2024

IF gin automatically implements binding routing, parameter verification, and generating swaggers, which can reduce a lot of workload when developing the web

type UserSearchReq struct {
g.Meta path:"/user/list" tags:"sysUser" method:"get" summary:"xxx"
DeptId string p:"deptId"
RoleId uint p:"roleId"
Status string p:"status"
}
type UserSearchRes struct {
g.Meta mime:"application/json"
UserList []*model.SysUserRoleDeptRes json:"userList"
}

type UserAddReq struct {
g.Meta path:"/user/add" tags:"sysUser" method:"post" summary:"xxx"
UserName string p:"userName" v:"required#User account cannot be empty"
Password string p:"password" v:"required|password#PWD account cannot be empty"
UserSalt string
}
type UserAddRes struct {
}

func GetUserList(c *gin.Context, req *UserSearchReq) (res *UserSearchRes, err error) {
// todo
}

func UserAddReq(c *gin.Context, req *UserAddReq) (res *UserAddRes, err error) {
// todo
}

from gin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.