Giter VIP home page Giter VIP logo

Comments (3)

FarmerChillax avatar FarmerChillax commented on September 27, 2024

As much as I want to upvote Strict compliance, but this is Break change. Unrealistic :p

some case:

from gin.

mgerasimchuk avatar mgerasimchuk commented on September 27, 2024

@xr I think it would be better to keep this issue in open state as an improvement reminder for the next major version of the gin

it's extremely disorienting that I must not use the gin.Context and need to use (*gin.Context).Request.Context() instead

PS:
I faced the similar situation with otel like @pepea23 in #3993, and when I found that my otel.Span just disappeared from the context I was very surprised

PPS:
Another funny thing that there is no one sample in the gin's documentation with the context usage in a case when we should pass it deeper to other components. I think it should the very first line in the README, for real

from gin.

xr avatar xr commented on September 27, 2024

@mgerasimchuk sure, i just reopen this issues, and fyi, cross posting the discussions in the style guideline repo: google/styleguide#850

from gin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.