http method name in uppercase is too ugly.. about gin HOT 18 CLOSED

Agree with it.

from gin.

FYI, see https://code.google.com/p/go-wiki/wiki/CodeReviewComments#Initialisms.

from gin.

It's also consistent with the routing framework used (julienschmidt/httprouter).

from gin.

It's actually the way HTTP methods should be see
http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9

Now, with the Initialisms rule from naoina's link, I recommend they stay.

from gin.

I also think that using capitalized GET and POST is a good way to understand that methods create a GET and POST route respectively, we are not getting a value or posting whatever.

In fact gin.Context has a method called Get(key), it's a helper to get a value from the hash map, if the key doesn't exist, it would panic.

from gin.

So, hoping to use the first letter capitalized in such a way ..
Get Post Put etc.

+1

from gin.

Capitalized is more readable.

from gin.

+1 for Get, Post, Put, etc

from gin.

I also think that using capitalized GET and POST is a good way to understand that methods create a GET and POST route respectively, we are not getting a value or posting whatever.

This was exactly my intention and the reason why it is used this way in the HttpRouter package.

from gin.

EITHER will be fine to me.

from gin.

I think that lowercase is better - all your routes will generally be defined together so it's obvious that it's not a "get something" method call. I think the only way to decide what option to use is to decide if you want to completely follow the "official" code style, which IMO is a good decision because following that guide means that this issue would never have come up in the first place :) that's just what I think anyway.

from gin.

As noted above, this is not against the code guidelines.

from gin.

@julienschmidt ah you're right, apologies - in that case I say leave it as is because they do follow the guidelines.

from gin.

I understand that Get, Post, Put may look better for some people, but since it's already capitalized I do not think it's a good idea to change it. The document referred by @naoina is also a good source to leave it as is.

And, if we change POST() to Post(), should we also rename context.JSON() to context.Json()?

from gin.

And, if we change POST() to Post(), should we also rename context.JSON() to context.Json()?

Definitely if you do so.

from gin.

Just a simple silly comment, does this solve your problem? 😄

r := gin.Default()
var Get = r.GET
Get("/", home)

Not only it's a Get now, but it also doesn't have r. 😄 .

Again I recommend keeping them in caps as they are inline with their HTTP meaning.

from gin.

hahaha brilliant fix

from gin.

Well done!

from gin.