OS X "Retina" support in editor GUI about godot HOT 24 CLOSED

Done by 9b1f823! 🎉

from godot.

Sorry to hurt your eyes :P I think Godot supports exporting OSX Apps with HDPI, but I haven't tested it. I don't have any device with HDPI display so I'll either have to wait for the day I can purchase one, or someone contributes a patch, as changing the default theme for HDPI should be relatively easy.

from godot.

I'll look into it tomorrow.
On 11 Feb 2014 01:52, "okamstudio" [email protected] wrote:

Sorry to hurt your eyes :P I think Godot supports exporting OSX Apps with
HDPI, but I haven't tested it. I don't have any device with HDPI display so
I'll either have to wait for the day I can purchase one, or someone
contributes a patch, as changing the default theme for HDPI should be
relatively easy.

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-34719332
.

from godot.

Actually on second thought, it would probably be a little more difficult. Most of the editor uses containers, so increasing the font size is a non issue, but I guess all the icons in tools/editor/icons would need to be remade in higher resolution, which sounds like considerably more work.. Maybe using an algorithm like EAGLE would work? :)

from godot.

The approach a lot of applications take is to scale icons up but make sure
text is rendered nicely, as a quick hack. It looks much better, even if the
icons look a bit rubbish. Getting high dpi text/canvas support out and then
focusing on making it look pretty might be a good idea.
On 11 Feb 2014 02:10, "okamstudio" [email protected] wrote:

Actually on second thought, it would probably be a little more difficult.
Most of the editor uses containers, so increasing the font size is a non
issue, but I guess all the icons in tools/editor/icons would need to be
remade in higher resolution, which sounds like considerably more work..
Maybe using an algorithm like EAGLE would work? :)

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-34720265
.

from godot.

The funny thing is, Godot's built-in 2d scaling actually looks pretty good; I know because I'll be relying on it for resolution-independent UIs and I've tested it by rendering a 2d scene made for 1024x768 at 2048x1536. Whatever OSX is doing, it looks like trash. Really, it can't even bother to filter it? Maybe as an interim quick fix, whenever the window is resized on high dpi displays, it can use the set_size_override to be half the size of what the actual window size is, and enable stretching.

from godot.

This is what I got on retina MacBook Pro. Additionally I can't click any button. only "mouse down:" appears in console. When I maximize windows glitches dissapear but still I cannot press any buttons and because of that do anything in Godot.

from godot.

What version of MacOS are you running solgar ? I have a 15 rMBP and I don't have this problem.

from godot.

Version before Mavericks. But I cannot reproduce it with newest binary and it works as it should.

from godot.

After this merge on the retina display it doesn't take into account my resolution and starts in full retina resolution which is impossible to see

from godot.

The only solution is to buy the newest Mac obviously

On Fri, Feb 21, 2014 at 2:33 PM, Tudorica Constantin-Alexandru <
[email protected]> wrote:

After this merge on the retina display it doesn't take into account my
resolution and starts in full retina resolution which is impossible to see
[image: screen shot 2014-02-21 at 19 31 53 1 2]https://f.cloud.github.com/assets/205058/2232582/26783420-9b1e-11e3-9abe-6ca9419bafa1.png

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-35753183
.

from godot.

should I revert it or this can be fixed?

On Fri, Feb 21, 2014 at 2:33 PM, Tudorica Constantin-Alexandru <
[email protected]> wrote:

After this merge on the retina display it doesn't take into account my
resolution and starts in full retina resolution which is impossible to see
[image: screen shot 2014-02-21 at 19 31 53 1 2]https://f.cloud.github.com/assets/205058/2232582/26783420-9b1e-11e3-9abe-6ca9419bafa1.png

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-35753183
.

from godot.

I'm not sure if that merge is the cause or if another one produced it :)

from godot.

hmm :( and I don't have a retina display to test, so I guess the only
choice I have is, unless someone with retina / non retina can make a patch
to fix this is to revert

On Fri, Feb 21, 2014 at 2:43 PM, Tudorica Constantin-Alexandru <
[email protected]> wrote:

I'm not sure if that merge is the cause or if another one produced it :)

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-35754167
.

from godot.

Don't revert it! It didn't introduce the problem I'm having. Gonna play a little while with git and see if I can figure out what did.

from godot.

@tudalex, on my MBPr 15", Godot did not open in scaling compatibility mode, even before my changes. My change simply does exactly the window size backing conversion that was already being done in windowDidResize(), but on window initialization too.

I believe what happened for you is that you changed your AppKit version from something pre 10.6 to something newer. That, or your MAC_OS_X_VERSION_MAX_ALLOWED otherwise changed since your last build.

from godot.

I also have a 15" MacBook Pro Retina, and unfortunately, find it unusable in this state. Everything is so tiny....

While the older version was quite a bit uglier on a screen like this, it was usable. This is not usable. I don't have the programming prowess to fix it, unfortunately, but I think it should at least be rolled back to what the first screenshot looks like for a 1.0 release. Usable beats ugly any day. My two cents.

from godot.

agreed, i didn't know it looked like this in a retina display. I don't have
any device with this capability.

Do you know what needs to be changed in the OSX port for it to return to
normal?

On Thu, Oct 16, 2014 at 2:24 AM, jcs224 [email protected] wrote:

I also have a 15" MacBook Pro Retina, and unfortunately, find it unusable
in this state. Everything is so tiny....

[image: screen shot 2014-10-15 at 11 18 56 pm]
https://cloud.githubusercontent.com/assets/6226188/4657906/fd265562-54f3-11e4-8286-1c4219d16e64.png

While the older version was quite a bit uglier on a screen like this, it
was usable. This is not usable. I don't have the programming prowess to fix
it, unfortunately, but I think it should at least be rolled back to what
the first screenshot looks like for a 1.0 release. Usable beats ugly any
day. My two cents.

—
Reply to this email directly or view it on GitHub
#20 (comment).

from godot.

It looks like the change to this new system happened in this commit, 3974a5e. Perhaps we can try going back and working from there? I can also try it tonight when I get home from work.

from godot.

Again, that change isn't responsible for things looking tiny on a retina display. Things look tiny because the UI layout code is probably using absolute values for component sizes, instead of something modern like a weighted relative layout system. Reverting that change wont resolve the issue. It will make the screen take up 1/4 the window size. If fixing the layout isn't in the plans, you'll want to create a non-retina compatible window.

from godot.

fixing layout is out of the question for now. For that i'd need to get
access to a retina-compatible disiplay device, and for the time being that
is prohibitively expensive in Buenos Aires. so, how do you crate a
non-retina compatible window?

On Sat, Oct 18, 2014 at 6:34 AM, Kevin Hartman [email protected]
wrote:

Again, that change isn't responsible for things looking tiny on a retina
display. Things look tiny because the UI layout code is probably using
absolute values for component sizes, instead of something modern like a
weighted relative layout system. Reverting that change wont resolve the
issue. It will make the screen take up 1/4 the window size. If fixing the
layout isn't in the plans, you'll want to create a non-retina compatible
window.

—
Reply to this email directly or view it on GitHub
#20 (comment).

from godot.

I got it. I was opening the straight binary pulled from Github to try and run this program, and doesn't allow Mac OS X to utilize its "Low Resolution" mode. When I download the binary from your website in the .app wrapper, it works fine!

from godot.

I'm running Linux on my MBP retina, so I have the same issue. Are the pane/menu/control sizes calculated from the font/icon sizes or do they have some other logic? Would it be feasible to introduce a scaling factor which would zoom all the fonts / icons / (maybe margins/paddings) with it? I can run godot on retina os x and linux so I would be glad to test it but I can try fixing it as well if I can get some tips on what's the most probably the reasonable way place in the code to do the scaling so it wouldn't be a patchwork all over the place.

from godot.

Assigning to @reduz who now has the appropriate hardware ;)

from godot.