Giter VIP home page Giter VIP logo

Comments (5)

 avatar commented on May 15, 2024

haha wow and i thought it wasn't working. I'm not sure why the code for setting the icon in X11 works so weird, I checked it many times and it seemed OK to me, but i can't get it to work.

it's in platform/x11/os_x11.cpp function set_icon() , if anyone has any idea why it might not work, it's very welcome.

from godot.

Terseus avatar Terseus commented on May 15, 2024

After some testing I made it work changing the wr pointer in this line from uint32_t* to long*.

I think the problem is related with types sizes; the long type size is 8 bytes in x86_64 POSIX systems while uint32_t type size is always 4 bytes, so that was casting an 8-byte type to an 4-byte type.

Sorry, I'm a noob with Github, give me some time and I will send a pull request with this change ^_^

from godot.

vinzenz avatar vinzenz commented on May 15, 2024

Fixed by 58cda02

from godot.

reduz avatar reduz commented on May 15, 2024

good for you, the icon still does not display on ubuntu :(

On Thu, Feb 13, 2014 at 7:13 PM, Vinzenz Feenstra
[email protected]:

Fixed by 58cda0258cda02

Reply to this email directly or view it on GitHubhttps://github.com//issues/52#issuecomment-35032703
.

from godot.

 avatar commented on May 15, 2024

well, guess this was fixes anyway, so closing

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.