google / localtoast Goto Github PK

License: Apache License 2.0

Go 99.45% Makefile 0.28% Shell 0.28%

localtoast's Issues

Consider adding `/scannerlib/proto` as part of source control

Currently, in a clean repo state, the Go module has unknown dependencies that exist only after a build has happened (or the build-proto.sh script is run):

❯ go mod tidy
go: finding module for package github.com/google/localtoast/scannerlib/proto/severity_go_proto
go: finding module for package github.com/google/localtoast/scannerlib/proto/compliance_go_proto
go: finding module for package github.com/google/localtoast/scannerlib/proto/scan_instructions_go_proto
go: finding module for package github.com/google/localtoast/scannerlib/proto/api_go_proto
github.com/google/localtoast imports
        github.com/google/localtoast/scannerlib/proto/api_go_proto: no matching versions for query "latest"
github.com/google/localtoast/configs/genfullconfig/genfullconfiglib imports
        github.com/google/localtoast/scannerlib/proto/compliance_go_proto: no matching versions for query "latest"
github.com/google/localtoast/configs/genfullconfig/genfullconfiglib imports
        github.com/google/localtoast/scannerlib/proto/scan_instructions_go_proto: no matching versions for query "latest"
github.com/google/localtoast/configs tested by
        github.com/google/localtoast/configs.test imports
        github.com/google/localtoast/scannerlib/proto/severity_go_proto: no matching versions for query "latest"

❯ make
./build_protos.sh
--2022-09-06 17:37:44--  https://github.com/grafeas/grafeas/archive/0163b5bb2ff5afbf059ddf472fb4d128faae85e3.tar.gz
Resolving github.com (github.com)... 192.30.255.112
Connecting to github.com (github.com)|192.30.255.112|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/grafeas/grafeas/tar.gz/0163b5bb2ff5afbf059ddf472fb4d128faae85e3 [following]
--2022-09-06 17:37:45--  https://codeload.github.com/grafeas/grafeas/tar.gz/0163b5bb2ff5afbf059ddf472fb4d128faae85e3
Resolving codeload.github.com (codeload.github.com)... 192.30.255.120
Connecting to codeload.github.com (codeload.github.com)|192.30.255.120|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ‘0163b5bb2ff5afbf059ddf472fb4d128faae85e3.tar.gz’

0163b5bb2ff5afbf059ddf472fb4d128faae85e3.tar.gz                        [         <=>                                                                                                                                                  ]   9.24M  5.24MB/s    in 1.8s

2022-09-06 17:37:47 (5.24 MB/s) - ‘0163b5bb2ff5afbf059ddf472fb4d128faae85e3.tar.gz’ saved [9694009]

go build localtoast.go

After the fact, go mod is able to resolve the dependencies correctly. Looks like it's primarily the dependency on github.com/grafeas/grafeas. This creates an interlinking of code sources in the build tree that do not exist as part of the source control.

Would it be possible to add github.com/grafeas/grafeas as part of the source control? Possible as a git submodule or maybe a static code dependency?

This makes building from a airgapped / non-networked environment much more challenging since the entire source code is not in the base repo.

Need documentation on `protoc` buildtime dependency

On attempting to build the localtoast binary per the README.md instructions from the v1.1.4.3 code tarball:

❯ make
go install google.golang.org/protobuf/cmd/protoc-gen-go
protoc -I=. --go_out=. scannerlib/proto/*.proto
/bin/sh: line 1: protoc: command not found
make: *** [Makefile:5: localtoast] Error 127

Seems that it's expected to build the gRPC protos before a build is executed through the build_protos.sh script.

It'd be nice if this was documented or if there was a different make target provided that didn't require the protos to be created before the binary is built.

error scanning rocky linux instance

Running the following:
sudo ./localtoast --config=instance_scanning.textproto --result=scan-result.textproto

On one of my Rocky Linux machines I got the following error, consistently:

[file check on files_in_dir:{dir_path:"/proc" recursive:true skip_symlinks:true filename_regex:"current" opt_out_path_regexes:"/proc/[a-z].*"}]: readdirent /proc/921/task/921/net: invalid argument

OS version

cat /etc/os-release
NAME="Rocky Linux"
VERSION="8.5 (Green Obsidian)"
ID="rocky"
ID_LIKE="rhel centos fedora"
VERSION_ID="8.5"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Rocky Linux 8.5 (Green Obsidian)"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:rocky:rocky:8:GA"
HOME_URL="https://rockylinux.org/"
BUG_REPORT_URL="https://bugs.rockylinux.org/"
ROCKY_SUPPORT_PRODUCT="Rocky Linux"
ROCKY_SUPPORT_PRODUCT_VERSION="8"

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.