Giter VIP home page Giter VIP logo

Comments (6)

adamraine avatar adamraine commented on May 22, 2024 1

The Lighthouse Config type allows supportedModes on each category but the Result type does not. TS is accurately reporting that the field is incorrect.

The explanation seems like an actual issues since we set it but it's not on the types:
https://github.com/GoogleChrome/lighthouse/blob/main/core/audits/accessibility/axe-audit.js#L79

from lighthouse.

adamraine avatar adamraine commented on May 22, 2024 1

Okay interesting. Could you elaborate on the Config a bit? Or point me to docs. I don't fully understand how to use that, or why am I seeing supportedModes in the results?

Yeah I took a look at the generated results, and looks like we are emitting supportedModes on the result category even though it's not a part of the type. So I guess we should either remove that from the output or add supportedModes to the types.

from lighthouse.

hilja avatar hilja commented on May 22, 2024

Okay interesting. Could you elaborate on the Config a bit? Or point me to docs. I don't fully understand how to use that, or why am I seeing supportedModes in the results?

If I use Config.Category:

type CategoryConfig = Record<string, Config.Category>

Then it’s missing other properties like id and score.

I can extend the types and it seems to work:

type CategoryConfig = Record<string, Config.Category & Result.Category>

Is this correct usage?

Thanks!

from lighthouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.