Comments (6)
The Lighthouse Config
type allows supportedModes
on each category but the Result
type does not. TS is accurately reporting that the field is incorrect.
The explanation
seems like an actual issues since we set it but it's not on the types:
https://github.com/GoogleChrome/lighthouse/blob/main/core/audits/accessibility/axe-audit.js#L79
from lighthouse.
Okay interesting. Could you elaborate on the Config a bit? Or point me to docs. I don't fully understand how to use that, or why am I seeing supportedModes in the results?
Yeah I took a look at the generated results, and looks like we are emitting supportedModes
on the result category even though it's not a part of the type. So I guess we should either remove that from the output or add supportedModes
to the types.
from lighthouse.
Okay interesting. Could you elaborate on the Config
a bit? Or point me to docs. I don't fully understand how to use that, or why am I seeing supportedModes
in the results?
If I use Config.Category
:
type CategoryConfig = Record<string, Config.Category>
Then itβs missing other properties like id
and score
.
I can extend the types and it seems to work:
type CategoryConfig = Record<string, Config.Category & Result.Category>
Is this correct usage?
Thanks!
from lighthouse.
Related Issues (20)
- SyntaxError: The "start lh:runner:gather" performance mark has not been set HOT 2
- Protocol error (Tracing.start): Tracing has already been started (possibly in another tab). HOT 5
- Color contrast error: cannot read `getCellFromPoint` HOT 4
- LCP Element is not visible when the LH Audit gets started programatically HOT 3
- Google chrome headless is rendering html as mobile view HOT 1
- Get CLS of 0 in timespan even though navigate gives a nonzero CLS value HOT 2
- Update "Using Lighthouse as a trace processor" docs HOT 3
- Feature Req.: Accessibility: check for correct markup of language HOT 1
- Lighthouse tests on the crypto exchange website Binance.com give varying scores and persistent issues that I am not sure how to interpret.
- Executing lighthouse lic gets stuck in alpine nodejs environment HOT 5
- Lighthouse User Flow doens't work in Docker HOT 5
- Unable to connect to Chrome HOT 1
- ..
- browser extensions HOT 2
- Lighthouse warns when an anchor tag is just a placeholder HOT 6
- a11y gatherer hangs on https://almanac.httparchive.org/en/2021/ecommerce HOT 7
- Improve `runtimeError` HOT 1
- Lighthouse fails to produce accessibility score altogether for incomplete axe-core result HOT 4
- People detect Lighthouse to cheat its performance score HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lighthouse.