Giter VIP home page Giter VIP logo

Comments (7)

connorjclark avatar connorjclark commented on May 16, 2024 1

It will still run in axe, since we don't connect our audit ids to the axe config like that (but we should ..)

from lighthouse.

connorjclark avatar connorjclark commented on May 16, 2024

target-size is taking forever.

from lighthouse.

tunetheweb avatar tunetheweb commented on May 16, 2024

FYI I have "identical-links-same-purpose": "off", in my config.

Will try it with target-size turned off too...

from lighthouse.

adamraine avatar adamraine commented on May 16, 2024

I think we should upstream this bug to axe if we can. Even though the audit is hidden, we eventually want to use it and I think disabling it completely will lose value in HTTPA runs (ironic that this happens on https://almanac.httparchive.org/en/2021/ecommerce tho haha).

from lighthouse.

tunetheweb avatar tunetheweb commented on May 16, 2024

FYI, I also saw problems with https://almanac.httparchive.org/en/2021/webassembly

Both have a lot of web mentions (which we render at the bottom of the page). Turning this functionality off (https://almanac.httparchive.org/en/2021/webassembly?nowebmentions) allowed the page to pass Lighthouse runs.

So either the DOM's got too large with those, or axe doesn't handle a page with a lot of similar things. A lot of them do have the same "View Source" link despite pointing to different sources which might fail the new identical-links-same-purpose (docs) audit?

image

from lighthouse.

connorjclark avatar connorjclark commented on May 16, 2024

target-size is taking forever.

should clarify, of that commit i bisected to this was the only thing that was a problem. Disabling target-size axe check was the only thing necessary to allow the run to finish.

from lighthouse.

adamraine avatar adamraine commented on May 16, 2024

dequelabs/axe-core#4360

We can disable the target-size rule temporarily. If axe fixes this issue or we decide to elevate target-size to the report UI then we should re enable it.

from lighthouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.