hellosiyan / viewnior Goto Github PK

Environment

My Linux distribution Manjaro 17.1.12 provides Viewnior 1.6 as default image viewer. I like to managed my JPEG images taken with an arbitrary iPhone model.

Issue

While rotating an image Viewnior 1.6 ignores the orientation tag from the Exif data. Instead it rotates the image itself, leaving the orientation as is. As a result, reloading an already rotated image in Viewnior, the orientation from the Exif data is applied, displaying the image with wrong orientation.

Expectation

If the Exif orientation tag is present, Viewnior should apply the rotation to the Exif orientation tag, leaving the image as is.

If the Exif orientation tag is not present, Viewnior should either add the Exif orientation tag if other Exif data is present, or should be allowed to rotate the image itself if any Exif data is absent.

Hello, Viewnior is great, but recently I was curating some photos and misclicked and deleted the wrong one. It was no big deal, but it would be great if such mistakes were reversible.

Some of the mouse buttons have some options as is, but it would be nice if all mouse buttons, including the ones not always present could be configured to do either do native actions or call external commands. Openbox, & presumably some similar window managers will let you do some of this with some buttons, but it would be a lot easier to make it Viewnior specific if Viewnior did it itself.

support copy image to clipboard,Tks~

Hi, this would make my like so much easier.

Any chance you might add this, or should I fork and roll my own version? :)

Thanks for your work, by the way!

Viewnior started from tirminal with command

viewnior -9lguJCz_z4.jpg

Expected

Open a file

Happened

Unknown option -9lguJCz_z4.jpg
Run 'viewnior --help' to see a full list of available command line options.

Enviroment

• Arch Linux
• Viewnior 1.7

Just upgraded on Fedora
in fullscreen the border is now white instead of black (and no option to change it)
for me it's a bug not a feature

Also missing the f key to go to 100% as seen in earlier versions.

and thx for this amazing picture viewer

So..
Recently most of the downloaded from the internet images are not recognizable by the app.
In this case is an normal jpg file, which can be opened by for eample Pix, XnView etc. without any problems. But not by the Viewnior.
The issue also applies to other file formats like png, tiff, gif, etc. as well.
Like on the screenshot..

Here is the example file..

My system: Mint 18.3 Mate x64.
And here is report from inxi:
inxi-report.txt

I believe gnome's image viewer has it.

Currently to access the cropping functionality it's either click+mousemove+mousemove+click or click+i+i+right+up+up+enter or tab+right+right+right+right+right+right+right+right+enter+i+i+right+up+up+enter.
A shortcut key combo would make life a bit easier. In GIMP it's Shift-C.

Hi, I'm running manjaro with xfce which use viewnior as it's default image viewer. But when I right click on the image in viewnior and choose "set as wallpaper", there is nothing happening. I've set xfce as my DE in "preference" and I've also tried to install feh but that didn't seem to help.

Here is the same problem: https://forum.manjaro.org/t/bug-cant-set-wallpaper-from-right-click/34649

It is 23 months since last version and there are some commits since then.

As tested with XFCE 4.14 in Arch Linux, attempting to set the wallpaper from Viewnior has no effect. I tried versions 1.8 and commit 9160eaa from the master branch.

I am using Elementary OS 5.0 Juno, and willing to install Viewnoir.
Unfortunately, during the building process, this is what I am presented with

The Meson build system
Version: 0.48.2
Source dir: /home/user1/Downloads/Viewnior-viewnior-1.7
Build dir: /home/user1/Downloads/Viewnior-viewnior-1.7/builddir
Build type: native build
Project name: viewnior
Project version: 1.7
Native C compiler: cc (gcc 7.3.0 "cc (Ubuntu 7.3.0-27ubuntu1 ~ 18.04) 7.3.0")
Native C++ compiler: c++ (gcc 7.3.0 "c++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0")
Build machine cpu family: x86_64
Build machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Dependency gtk+-2.0 found: YES 2.24.32
Dependency glib-2.0 found: YES 2.56.3
Dependency gio-2.0 found: YES 2.56.3
Dependency shared-mime-info found: YES 1.9
Dependency gdk-pixbuf-2.0 found: YES 2.36.11
Dependency exiv2 found: NO (tried pkgconfig)

meson.build:25:0: ERROR: Dependency "exiv2" not found, tried pkgconfig

A full log can be found at /home/user1/Downloads/Viewnior-viewnior-1.7/builddir/meson-logs/meson-log.txt`

This, in spite of the latest version of exiv2 being installed on my computer
Please find attached the full Meson log
meson-log.txt

A middle button press action or panel gui button, that switches scrolling through images and zooming behaviour.
For example

• viewnitor always starts with scrolling behaviour
• after finding proper image pressing mmb allows to zoom in/out
• next mmb press reveals back scrolling behaviour to find next image.

The gif file in question: https://raw.githubusercontent.com/Somerset-Recon/blog/master/Eldrax/images/table_view.gif

Firefox loads this gif fast and without any noticeable memory usage. Viewnior may have a memory leak or is loading the gif inefficiently. It may also be the fault of the library used to load the gif.

Viewnior responds to button 9 on a Logitech M-570 trackball by changing to the next image, as if it were a scroll down. This makes it impractical to use button 9 for other purposes. Is there any way to stop it from doing that? It doesn't seem to be documented.

When running Viewnior 1.7 on macOS 10.13.5 from the terminal, I get the following dire warning:

WARNING!!! WARNING!!! WARNING!!! WARNING!!! WARNING!!! WARNING!!!
WARNING!!! WARNING!!! WARNING!!! WARNING!!! WARNING!!! WARNING!!!
WARNING!!! WARNING!!! WARNING!!! WARNING!!! WARNING!!! WARNING!!!
YOUR CODE IS RELYING ON DEPRECATED FUNCTIONALTIY IN THE JASPER LIBRARY.
THIS FUNCTIONALITY WILL BE REMOVED IN THE NEAR FUTURE.
PLEASE FIX THIS PROBLEM BEFORE YOUR CODE STOPS WORKING!
The specific problem is as follows:
negative buffer size for jas_stream_memopen

Despite the warnings, images display fine, so it's not causing a (visible) problem.

Hello!

I am a long time user of Viewnior and it is my default viewer in Linux Mint XFCE. In Windows there is a nice viewer (IrfanView, I imagine you know it) and besides its fast navigation, there is an option to rename files just by pressing F2. In Linux, I have seen this only in Mirage, but this viewer has the awful problem that you can't navigate fast enough and using the keyboard keys).

Is this feature (the option to rename a file) too dificult to implement in Viewnior? This is the only reason I always need to install more than one viewer (just for renaming I have kep Mirage, because I manage folders with hundreds or thousands of photos I need to organize)

Thanks in advance

This isn't an issue; instead it's a compliment.

Two main things I think would be great enhancements to svgs

re-render/rasterize an svg on each zoom

right now, an svg is only rasterized into a bitmap once, then if the user zooms in our out, it we are dealing with the fuzzy image. SVGs are vectors, and so we lose some of the advantages of viewing one.

render svgs to fit the screen by default

svgs are vectors, so the size that they initially have marked is not actually all that relevant, except maybe in showing how it will look in say a browser without any styling. I propose that by default, an svg should be drawn to fit the viewer in full, and hitting the "normal size" button will display it using the height and width values in the .svg file

Installed Viewnior after trying many others including Gthumb, Mirage etc and like V the best so far with one tiny exception. i can't figure out the slideshow order, it appears to be random? It would be great to be able to set it for mod date, or name etc. Even if it had to be done in the config file.
And my suggestion is not functionality related but appearance - a dark theme would be great and seems like most everything is dark these days anyway. Thanks for an awesome app!

Thanks for your work!

Pretty much $subject. I suggest R since <control>R and F5 are already taken.

I'm running viewnior 1.7 on Fedora 29 (gnome on wayland) and I'm having trouble with keyboard shortcuts.

I've used viewnior on other distros in the past and I'm sure I remember being able to press 0 to fit the current image to the window (as View->Best Fit does from the menu). Well, I may be wrong about that, but whenever I press 0 now I get the following error:
GLib-GObject-CRITICAL **: 11:27:23.139: g_value_get_enum: assertion 'G_VALUE_HOLDS_ENUM (value)' failed

I have also tried editing ~/.config/viewnior/accel_map but I'm unable to get any of my edits to be recognised. Also, when I access certain menu items within viewnior, this file is overwritten with a default version and none of my changes remain.

Currently no keybinding for rotating it? (v and h flip it though) Could also show what keybinding it is in the "onhover" text, and just state the keybindings in menus?

Could have : show a menu of all the possible actions that selects through as you type, selecting one and hitting enter runs it. But maybe that's a bit much.

I have reduced slideshow-timeout value to 2, but when i start a slideshow, it always runs with default internal setting.
In tool-bar the value looks the same as configuration file, but i have to re-apply it in order to take effect. I also tried with highest value, but had the same behavior.

Sorry for the bad English!

version: aac0a0c

UPDATE:
The same even if i change the value in vnr-pref.c file.

If you have a folder with thousands of images, you can navigate through them using RePag and AvPag keys.

It will be very useful if you can configure that pressing simultaneously keys Shift + RePag or Shift + AvPag to navigate to the 10th next or 10th previous image in this folder (or the 20th, maybe it could be configurated in a settings param). It could be used to navigate in folders where you store bursts of images, mostly of them very similar and you want to show or navigate through them faster.

When opening the JPEG2000 sample file from https://www.fnordware.com/j2k/jp2samples.html, viewnior crashes with a segfault (both the released version and git master).

relax.jp2.tar.gz

$ src/viewnior ~/Projects/jpeg-decoder/fuzz-afl/in/relax-jpeg2000.jp2
ICC Profile CS 52474220
viewnior: /build/jasper/src/jasper-version-2.0.16/src/libjasper/jp2/jp2_dec.c:308: jp2_decode: Assertion `dec->image->cmprof_' failed.
Aborted (core dumped)

I hope this is reproducible, if not I can provide a core dump.

That would be awesome to have printing option out of viewnior.
Right now I'm using Open in Gimp and then print..

Running commands could be nice. For instance feh -A "mv %F ~/wherever, you can press 0 to move the file. But of course that could be anything. It could like open a text file kate ~%F.markdown or some such. Could allow specifying those both in the commandline and the ~/.config/ file. Of course preferably also attachable to key binding (#84)

I realize you can jigger the "open with" to do a similar thing by making a script one of the open with items, but it is very hard to control where it appears in the menu and Viewnior adds stuff to that menu making it unwieldy. It would be a lot nicer if the native menu were editable, perhaps with a config file kind of like 9menu menu files. Failing that, almost as good would be one entry in the top level of the menu that pointed to a standard path/filename that would call any script there the same way "open with" does, with the path/filename of the image file as an argument. Then we could put anything in the script, including another menu for example. 3rd choice would be for just the "open with" submenu to have the option to manually specify what's on it instead of having it change automatically.

The file viewnior.appdata.xml is a bit incorrect.
Here is the patch:

Index: Viewnior-viewnior-1.7/data/viewnior.appdata.xml
===================================================================
--- Viewnior-viewnior-1.7.orig/data/viewnior.appdata.xml
+++ Viewnior-viewnior-1.7/data/viewnior.appdata.xml
@@ -22,5 +22,5 @@
     <screenshot><image>https://siyanpanayotov.com/images/vnr_pref_window.png</image></screenshot>
     <screenshot><image>https://siyanpanayotov.com/images/vnr_navigation_window.png</image></screenshot>
   </screenshots>
-  <update_contact>contact_AT_siyanpanayotov.com</updatecontact>
-</application>
\ No newline at end of file
+  <updatecontact>contact_AT_siyanpanayotov.com</updatecontact>
+</component>

Could you include this information in the window "properties of the image"?
It will be helpful because sometimes after browsing many images I have to find the image in the file browser and then see the date there.

Right now the file name is displayed in the title bar, which is a bit of a problem for me as I use Manjaro I3 which doesn't have title bars. Would it be possible to either display it in floating text over the image (maybe a pop up if the cursor hovers over the image?) or perhaps a path drop down in the toolbar?

If Viewnior was run with --fullscreen, exiting from fullscreen leads to random window position and size (depends on opened image?). I think it shoud remember pervious postion or have setting for controlling such behavior. For example, if last time i closed Viewnior with expanded window, i expect that next time when i switching from fullscreen to windowed it will be expanded too.

I am a Manjaro XFCE user and find out that Viewnior 1.7 doesn't seems rotate or load the rotated JPG images for images taken from my phone: a Xiaomi Mi 9. But for a couple of JPG images which are not taken from my phone Viewnior seems save rotation information and load them fine.

When I tried to open one of the not working images taken from my phone in GIMP and GIMP warned me about images with Exif orientation metadata, and ask me to choose either the original image (which has been rotated correctly) or the one been rotated (which is the one I was trying to rotate as the orientation was wrong), and that make me believe it's related to issue #45.

it's worth noting that I am also a Manjaro user and I am using Xfce as my desktop envirement. It's I am merely following an post in Manjaro forum from another Manjaro user and following his link to the issue #45, and thought that it might be a better idea to post it as a seperate issue and post the link in #45.

Hi

Can I please request a simple save-as feature?

when I take a screenshot it saves in my /tmp/ directory and I always forget its there

I often crop the image too and want to save the crop as a different file

thanks!

First: thank you for this awesome piece of software.

When viewing images with an alpha channel, viewnior applies a checker background behind. This is sometimes useful, but sometimes bad for visibility. In my case, I'd like to watch CAD drawings exported to svg before sending them for laser cutting. It is made mostly out of thin lines that are hardly visible over a checker pattern.

It would be nice to have an option to set a uniform color instead.

For example, this is how eog manages this option:

Selecting a portion of a screenshot to crop is very difficult to do when the crop preview is so small compared with the size of the image. It would be great if cropping could be done in the primary image viewport.

Using Version 1.7 of Arch Linux.

The file will be deleted successfully. So there might be only this missing text block bug.

Result in the command line:

(viewnior:5360): Gtk-WARNING **: 12:48:24.298: Failed to set text from markup due to error parsing markup: Error on line 2: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity ? escape ampersand as &

The relevant code is at about "src/vnr-window.c" line 1605. Maybe using g_markup_escape_text() (as I read) could resolve this but I'm not sure if this is correct. There could be other places in the code with the same error.

One of the more common operations that a normal user does with an image viewer is to make it fullscreen, but Viewior does not seem to provide one.

Could you add support for a simple keyboard shortcut like “f” to make Viewnior fullscreen?

When using the zoom (scrolling up/down) the touchpad is very sensitive to horizontal scroll, which changes to the next picture. It is nearly impossible to scroll perfectly vertical. Because the picture is changed to the next one, the zoom did not do what it was intended to do.

System: Arch Linux x64, XPS 13 (9360), viewnior 1.7

Potential fix:
In the settings of viewnior there is an entry for setting the action on using the mousewheel. If this setting could be refined for horizontal and vertical mousewheel that could solve the problem.
Otherwise, the threshold for going to the next picture could be decreased.

Could you please add .webp format support to Viewnior?

I have noticed that there is a 7 year old branch named gtk3. Since rarely any app is still using gtk2 novadays, it would make sense to consider merging this branch and offering gtk3 as default.

Thoughts? Would it even be possible? Where would I need to start looking in order to add a new format?

I would like to request the addition/development of a status bar (it can be hidden by default and hideable) that shows what's currently shown in the title. The information, doesn't have to be removed from the title or anything, it can show in both places or maybe you can choose where to show it.

Hello @hellosiyan !

First, a huge thanks for your image viewer I just discovered and which is really light & fast !
I was kinda desperate to find such a tool, and I'm happy now !

Since Viewnior is fast, I think it is a great tool for browsing thru & culling images.
What I miss is the ability to keep the zoom unchanged while going to the previous or next image(s).

I usually do this when I shot a burst of images (which are thereforr almost identical) and the one I'll keep will be the sharpest one.
Keeping the zoom unchanged is therefore very useful in such a situation.

Do you foresee this as a possible option in the future ?

Thanks
GLLM