Giter VIP home page Giter VIP logo

Comments (7)

DanielOndiordna avatar DanielOndiordna commented on May 20, 2024 1

My player tracker add-on plugin already adds permanent player names as labels to the markers.
https://softspot.nl/ingress/plugindetails/iitc-plugin-player-tracker-addon
This plugin adds Leaflet.iconlabel:
https://github.com/jacobtoye/Leaflet.iconlabel

from ingress-intel-total-conversion.

xscreach avatar xscreach commented on May 20, 2024 1

@DanielOndiordna thanks! I still think this would be a useful optional feature to contribute into the official plugin :) also I think it would be useful to display the machina movement (e.g. with white icon), also optionally.

Imho a good idea πŸ‘
Just note that Machina movement is handled by machina-tracker plugin πŸ˜‰

from ingress-intel-total-conversion.

johnd0e avatar johnd0e commented on May 20, 2024

For example, it could be used in player-tracker in order to provide (optionally) permanent labels for players' nicks.

player-tracker code is not great. E.g. this part currently seems do nothing:

if(obj.layer === plugin.playerTracker.drawnTracesEnl || obj.layer === plugin.playerTracker.drawnTracesRes) {
obj.layer.eachLayer(function(marker) {
if(marker._icon) window.setupTooltips($(marker._icon));
});
}
});

Similar code is here

// jQueryUI doesn’t automatically notice the new markers
if (!isTouchDev) {
window.setupTooltips($(m._icon));
}

And here and there I see workaround if form of force calling closeIconTooltips

// force close all open tooltips before markers are cleared
window.plugin.playerTracker.closeIconTooltips = function() {
plugin.playerTracker.drawnTracesRes.eachLayer(function(layer) {
if ($(layer._icon)) { $(layer._icon).tooltip('close');}
});
plugin.playerTracker.drawnTracesEnl.eachLayer(function(layer) {
if ($(layer._icon)) { $(layer._icon).tooltip('close');}
});
}

I suppose that using leaflet native tooltips instead of jQueryUI would be much easier and do not require any special handling, we just need bindTooltip here:

var m = L.marker(gllfe(last), {icon: icon, referenceToPortal: closestPortal, opacity: absOpacity, desc: popup[0], title: tooltip});

But as for initial intention (bindTooltip with permanent: true option on every marker) then we should consider to apply special tooltips styling (default is not good for dense areas).

from ingress-intel-total-conversion.

johnd0e avatar johnd0e commented on May 20, 2024

Also we could use tooltips with portal markers, to display title if available (or some other info in concise form).

To avoid tooltip overlapping: https://github.com/ZijingPeng/leaflet-tooltip-layout

from ingress-intel-total-conversion.

Gollam avatar Gollam commented on May 20, 2024

Hi @modos189, I just had the idea of showing agent names in player tracker, and I found this open issue. Do you think I should try to write some code for it?

from ingress-intel-total-conversion.

Gollam avatar Gollam commented on May 20, 2024

@DanielOndiordna thanks! I still think this would be a useful optional feature to contribute into the official plugin :) also I think it would be useful to display the machina movement (e.g. with white icon), also optionally.

from ingress-intel-total-conversion.

Gollam avatar Gollam commented on May 20, 2024

@xscreach thanks! I'll check it.

from ingress-intel-total-conversion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.