Giter VIP home page Giter VIP logo

Comments (3)

nasimsaleh avatar nasimsaleh commented on May 18, 2024

@ugurdogrusoz I already pushed it before seeing the created issue here.
43916e1

from cytoscape.js-layout-utilities.

ugurdogrusoz avatar ugurdogrusoz commented on May 18, 2024

Works nicely. One more improvement could be as follows. Among all those locations yielding the same adjusted fullness, looks like we're settling for an arbitrary one. Shouldn't we settle for the one yielding the biggest fullness?
For example same graph with d.a.r. of 1.25:
125

vs. d.a.r. of 1.50:
150

With the latter, we're wasting space unnecessarily, as the former clearly shows that there is a better packing with the same adjusted fullness.

Let's discuss.

from cytoscape.js-layout-utilities.

nasimsaleh avatar nasimsaleh commented on May 18, 2024

@ugurdogrusoz Now it is changed to look first at Adjusted Fullness, and if equal then Fullness and finally to the closer aspect ratio. However, the result might not change because in the example above the desired aspect ratio is different so the adjusted fullness will also be different because adjusted fullness = f(d.a.r)

from cytoscape.js-layout-utilities.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.