Comments (12)
Oh, jeez. :|
Will add this to v3 alpha.
from react-reorder.
I created an example of using babelify to support the usage of React.Component instead of React.createClass:
https://github.com/romamatusevich/react-reorder/commit/dacd021cc60f05e1a29ad6ce0448ffd491a33b2c
What do you think about creation of the support release 2.1.1 to prevent warnings with react 15.5.0? I understand that version 3 alpha is in development, but I am not sure that it is fully stable.
from react-reorder.
@romamatusevich it should me more stable than the existing versions, but I don't think enough people have tested it yet. I'll release a patch of version 2 with the react-create-class
lib, as I think the move to ES6 may cause issues with binding.
from react-reorder.
Sounds good. During testing I faced with binding issues and just added bindings to constructor:
constructor(props) {
super(props);
this.state = { list: this.props.list || [] };
this.dragScrollY = this.dragScrollY.bind(this);
this.onMouseUp = this.onMouseUp.bind(this);
this.onMouseMove = this.onMouseMove.bind(this);
}
from react-reorder.
Gonna release in a sec after a little testing. There's another couple of fixes that should go into v2. But I'll sort those out after this. :)
-
event.preventDefault
when dragging on mobile to prevent scrolling -
event.persist
for React 15+
from react-reorder.
@romamatusevich care to review? #80
from react-reorder.
@JakeSidSmith, sure, will review
from react-reorder.
With React v16 imminent, how about releasing v3?
from react-reorder.
@wmertens there are a couple of known bugs that need to be sorted first. Will try to sort these as soon as I can.
from react-reorder.
@JakeSidSmith Can you mark those in a milestone? I might be able to help a little bit
from react-reorder.
@wmertens keeping track of them here: #78
from react-reorder.
Gonna take a look at the unmounting bug today.
from react-reorder.
Related Issues (20)
- Unable to make 3.0.0-alpha.7 work with react 16.9 HOT 5
- Less performant deeper in the dom? HOT 1
- Please add events on "drag start" and "drag end" HOT 3
- Can't disable auto scroll HOT 7
- Another complete re-write in TypeScript, with hooks, React 16-17 support, and more HOT 4
- can't reorder
- TypeError: this.state.draggedStyle is null HOT 2
- Update PropTypes HOT 1
- Warning: This synthetic event is reused for performance reasons. HOT 3
- placeholder class is not added when dragging input fields HOT 3
- Overriding sorting behavior HOT 10
- V3 Alpha Issues HOT 47
- can't control dragged div HOT 17
- Images Reloading/Flashing HOT 9
- Error: Expected reorderId to be a string. Instead got undefined HOT 12
- Tidy up prop documentation in readme (v3) HOT 2
- Support React v16 HOT 11
- Issues with embedded images? HOT 6
- Unable to set reorder to a button HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-reorder.