Giter VIP home page Giter VIP logo

Comments (12)

JakeSidSmith avatar JakeSidSmith commented on May 24, 2024

Oh, jeez. :|

Will add this to v3 alpha.

from react-reorder.

romamatusevich avatar romamatusevich commented on May 24, 2024

I created an example of using babelify to support the usage of React.Component instead of React.createClass:
https://github.com/romamatusevich/react-reorder/commit/dacd021cc60f05e1a29ad6ce0448ffd491a33b2c

What do you think about creation of the support release 2.1.1 to prevent warnings with react 15.5.0? I understand that version 3 alpha is in development, but I am not sure that it is fully stable.

from react-reorder.

JakeSidSmith avatar JakeSidSmith commented on May 24, 2024

@romamatusevich it should me more stable than the existing versions, but I don't think enough people have tested it yet. I'll release a patch of version 2 with the react-create-class lib, as I think the move to ES6 may cause issues with binding.

from react-reorder.

romamatusevich avatar romamatusevich commented on May 24, 2024

Sounds good. During testing I faced with binding issues and just added bindings to constructor:

constructor(props) {
    super(props);

    this.state = { list: this.props.list || [] };
    this.dragScrollY = this.dragScrollY.bind(this);
    this.onMouseUp = this.onMouseUp.bind(this);
    this.onMouseMove = this.onMouseMove.bind(this);
}

https://github.com/romamatusevich/react-reorder/commit/dacd021cc60f05e1a29ad6ce0448ffd491a33b2c#diff-1fdf421c05c1140f6d71444ea2b27638R418

from react-reorder.

JakeSidSmith avatar JakeSidSmith commented on May 24, 2024

Gonna release in a sec after a little testing. There's another couple of fixes that should go into v2. But I'll sort those out after this. :)

  • event.preventDefault when dragging on mobile to prevent scrolling
  • event.persist for React 15+

from react-reorder.

JakeSidSmith avatar JakeSidSmith commented on May 24, 2024

@romamatusevich care to review? #80

from react-reorder.

romamatusevich avatar romamatusevich commented on May 24, 2024

@JakeSidSmith, sure, will review

from react-reorder.

wmertens avatar wmertens commented on May 24, 2024

With React v16 imminent, how about releasing v3?

from react-reorder.

JakeSidSmith avatar JakeSidSmith commented on May 24, 2024

@wmertens there are a couple of known bugs that need to be sorted first. Will try to sort these as soon as I can.

from react-reorder.

wmertens avatar wmertens commented on May 24, 2024

@JakeSidSmith Can you mark those in a milestone? I might be able to help a little bit

from react-reorder.

JakeSidSmith avatar JakeSidSmith commented on May 24, 2024

@wmertens keeping track of them here: #78

from react-reorder.

JakeSidSmith avatar JakeSidSmith commented on May 24, 2024

Gonna take a look at the unmounting bug today.

from react-reorder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.