Comments (12)
The config / markup has changed a lot for v3. Are you following the new readme?
https://github.com/JakeSidSmith/react-reorder/tree/rework#configuration
from react-reorder.
Just sorted that: https://github.com/JakeSidSmith/react-reorder/blob/master/README.md
Great minds. 😛
from react-reorder.
I'm hitting the same issue.
The only place where I've found reorderId
is on the rework
branch : https://github.com/JakeSidSmith/react-reorder/tree/rework
Current released version of the npm package is 3.0.0-alpha.2
so it's clearly OK for it to be unstable.
My guess is that the npm release is linked to rework
branch, but that we'd better install stable release.
I'll try to install the latest stable release, and update this thread if this works.
from react-reorder.
Oh right, that makes sense.
I was using master
branch README against v3 package. And think @13ms was doing the same.
I just yarn add [email protected]
and reorderId
error is gone.
@JakeSidSmith : For production software, is it better to use v3 alpha, or 2.2.1
is currently more reliable ?
from react-reorder.
Uhhh. Hard to say. Personally I'd go with v3, as if you are not using multiple lists (in v3 you can drag between lists) v3 has some bug fixes that are not in v2. Though there is a bug with the dragging between lists #78 (comment).
from react-reorder.
OK, I'll give a shot at v3, thanks !
Are you interested in a PR on master
's README pointing out that users of v3 should read the rework
README? This could avoid potential frustration for future users :D
from react-reorder.
Note: if using a component class / stateless component you will need to manually pass down the reorder props: #78 (comment)
Will hopefully find a way to avoid this in the future. 😄
from react-reorder.
Ignore what I said about the multi-list bug, forgot I had merged this: #83
from react-reorder.
Just to confirm that v3 is working perfectly ! IMO this issue deserves to be Closed 🙂
from react-reorder.
Will do. 😀
from react-reorder.
Except that npm install react-reorder installs v3, while GitHub shows the v2 docs.
from react-reorder.
NPM install always installs the latest version, which in this case is the alpha version. I may merge v3 as is to avoid confusion and continue work on it.
https://medium.com/@mbostock/prereleases-and-npm-e778fc5e2420
from react-reorder.
Related Issues (20)
- Unable to make 3.0.0-alpha.7 work with react 16.9 HOT 5
- Less performant deeper in the dom? HOT 1
- Please add events on "drag start" and "drag end" HOT 3
- Can't disable auto scroll HOT 7
- Another complete re-write in TypeScript, with hooks, React 16-17 support, and more HOT 4
- can't reorder
- TypeError: this.state.draggedStyle is null HOT 2
- Update PropTypes HOT 1
- Warning: This synthetic event is reused for performance reasons. HOT 3
- placeholder class is not added when dragging input fields HOT 3
- Overriding sorting behavior HOT 10
- V3 Alpha Issues HOT 47
- Warning with react 15.5.0 HOT 12
- can't control dragged div HOT 17
- Images Reloading/Flashing HOT 9
- Tidy up prop documentation in readme (v3) HOT 2
- Support React v16 HOT 11
- Issues with embedded images? HOT 6
- Unable to set reorder to a button HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-reorder.