Support React v16 about react-reorder HOT 11 CLOSED

@AntCrick @dargue3 @viztor should now work nicely with React 16.

from react-reorder.

@viztor this lib uses the create-react-class module, which should still be compatible with React 16.

If not, I will be re-writing v3 in ES6 / TypeScript, and so will using actual classes.

from react-reorder.

+1

I don't believe this works with React 16, unless you're saying we need to include create-react-class in our dependencies?

from react-reorder.

It is a dep of react-reorder: https://github.com/JakeSidSmith/react-reorder/blob/master/package.json#L34

Can someone explain what exactly is the issue with React 16? :)

from react-reorder.

+1 Though I think it could be an issue with the version that is on npm as i used npm install to install this and it's installed [email protected] and the react-reorder package.json doesn't have create-react-class in the dependencies that i can see so could be that maybe?

from react-reorder.

Ah, that's it! Thanks @AntCrick will update now and publish a new alpha version.

from react-reorder.

@AntCrick @dargue3 @viztor have published a fix at 3.0.0-alpha.5.

Please try this out, and if your issue is fixed, then close this issue. 🙂

from react-reorder.

I get Uncaught TypeError: Cannot read property 'oneOfType' of undefined because of

   ...
   var PropTypes = React.PropTypes;
   Reorder.propTypes = {
      component: PropTypes.oneOfType([PropTypes.func, PropTypes.string]),
   ...

And as it's said here https://reactjs.org/docs/typechecking-with-proptypes.html it is deprecated and moved to some package. What should I do to handle this problem?

from react-reorder.

Ah, poop. So many changes to make. Will try to get this sorted shortly.

from react-reorder.

Maybe it will help: there's recommendations for migrating

from react-reorder.

@birdy90 published some fixes at 3.0.0-alpha.6.

from react-reorder.