jakewharton / telecine Goto Github PK

On my Nexus 5, I've noticed Telecine being randomly killed (during recording) by the system. Calling startForeground() should go a long way to preventing this, I think.

Using the app icon is uggo because of the size of the widget.

It was the whole reason the option exists in the first place... -Dpre-dex=false

Android 6.0 now requires the user to grant permission explicitly in settings for an app targeting 23+ to have the SYSTEM_ALERT_WINDOW permission.
(activity.startActivityForResult(new Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION, Uri.parse("package:" + context.getPackageName())));)
Also, Telecine will have to ask for WRITE_EXTERNAL_STORAGE at runtime.

What are thoughts about Telecine targeting 23?
If it should, are there any preferences regarding the permission-granting flow?

To save me from myself (and people creating pull requests).

Some devices can only record up to 1080p. See #15.

Why can't it support older android version? For example: android 4.4.4 (KitKat)

Google Play description:
"This app is open source! Contribute by following the website link below."
Looks like the link didn't get pasted. :)
Sorry, I saw this a few months ago and then forgot about it until tonight. @JakeWharton

Since these options look like a preference list users tend to tap on the row instead of the Switch control.

While at it maybe add an optional text field for more information about the option, like the summary in a preference?

Is it possible to record with audio?

Since I updated my Nexus 5 to Android 5.1 the app crashes the "System UI" app when I click on the button 'launch overlay'.

Most of the time, Telecine will be killed by the system (probably lacking some RAM to restart the System UI processes) and it is impossible to do any screen cast.

If this is relatively easy to do we should just support it. Android supports this feature, but I have no idea how to leverage root for permission escalation.

What are your thoughts about a screenshot feature? This could exist as a toggle in the app between video recording vs. screenshot. When the overlay is launched in screenshot mode, a similar overlay could be launched. I'd imagine the overlay is immediately hidden when the capture button is pressed and reappears once the screenshot has been taken.

I have a friend who is partially paralyzed and has trouble using the hardware buttons to take screenshots. I planned on using this app as a base for a screenshot app (all the current ones on the market seem to be terrible). If it is something you may consider allowing into the app, I may just submit it as a pull request, rather than a separate app.

Thanks!

On a rooted LG G3 DUAL (LG-D858HK, LRX22G) Android 5.0, if I run Telecine, record a video and stop the video then turn off the screen (either manually or let it timeout), then after the screen is turned back on, and after some more time (variable, but usually minutes), the screen refresh rate becomes very jerky, gradually gets worse and the only way to get back to normal is to reboot the device. Force Stop on Telecine does not help.

Interestingly, if the screen goes off while the device is being charged, then the problem does not occur.

If I run the app while plugged in and Force Stop while still plugged in, then unplug, the refresh issue is still a problem.

Take Bug Report not working on this device, unfortunately, and I don't have access to the device generally.

Any ideas what could be causing this?

Just for information: Telecine is a brazilian entertainement trademark from Globo's news corporation. This could start some troubles/misunderstands in future. 😄

"Show touches" is still enabled even though I'm not recording. Please help!!! I have a circle following my finger on the screen!

Minor thing, but it is not ideal that the share action allows for a default application.
Perhaps get the PendingIntent for a BroadcastReceiver and then show the share Intent chooser/picker in the BR.

Otherwise people are stuck in this mode and they potentially don't even have developer options enabled.

Enable developer settings 'Show touches' options while recording.

Even though with Lollipop we have touch hints for visual feedback (ripples), there are still some missing like swipe and multitouch gestures.

Steps to reproduce:

• Launch the overlay
• Start the recording
• Wait a few seconds without doing anything
• Stop the recording

Results:
The video remains black.

It seems there is no key frame in the video...

This should probably be based on number of pixels. Then we can just use the same sizePercentage trick to scale the value.

Because otherwise how the hell do you know how to stop recording?

In my Nexus 6 and another test phone which I dont know its type ,Touch the clock area will not stop recording,but click the red area will work
@JakeWharton ,maybe edit the illustration?

I am using the latest source but sometimes i still receive the prepare fails exception until now all these devices have thrown java.lang.RuntimeException: Unable to prepare MediaRecorder :

HTC ONE (Screen resolution 1080x1920)
LGE lge LG-D415 (Screen resolution 540 x 960)
LGE google Nexus 4 (Screen res 720x1280)
Samsung Galaxy Tab2 (Screen res 600x1024)

I know this bug was supposed to be fixed but it still happens, i am also using 30 fps to avoid any issues. Any one here still receives this crash?

Unable to record when landscape is the initial orientation.
The crashlog is submitted through Google Play.

java.lang.RuntimeException: Unable to prepare MediaRecorder.
    at com.jakewharton.telecine.RecordingSession.startRecording(RecordingSession.java:180)

If Google doesn't screw me and close down permission on final.

https://newcircle.com/s/post/1745/2015/07/10/tweaking-system-ui-tuner

Google Analytics is so 2004

Google Analytics (and most likely bugsnag?) is non-free software, could you provide a gradle flavor that does not require this?

On Moto G (1 Gen - Lollipop), I have noticed if I on Hide from recent apps, still it shows in recent app list. Does it OS bug or what?

FABulous.

Why didn't I do this in the first place?!?

The navigation bar is often unnecessary to include in the recording - indeed, some devices don't have an on screen nav bar, so you wouldn't see it anyway.

It would be really good if this could be auto-cropped from the final video (with an appropriate setting to control this). I had a quick play with various height parameters in the code, but that only made the whole size smaller. So, I'm not sure how this can be done, or whether it can be done at all.

The alternative is to crop the video post-production which is obviously cumbersome. Indeed, I'm yet to find a decent tool on OS X, to do this well.

Hey,
How can I use the framework to stream realtime video to a receiving server?
Thanks!

This is convenient when you want another take on recording.

hi, im use Android 5.0.2
my device Redmi Note 3 (Mediatek)
when i click/touch launch overlay, nothing happen..
where is overlay for play or stop recording?

Via interactive crop overlay

For easily launching the overlay, and maybe replacing it?

These lines of code are computing the wrong video size:

    DisplayMetrics displayMetrics = context.getResources().getDisplayMetrics();
    int displayHeight = displayMetrics.heightPixels * sizePercentage / 100;
    int displayWidth = displayMetrics.widthPixels * sizePercentage / 100;

On a Nexus 6, the screen resolution is 1440x2560.
But, this DisplayMetrics will contain a size of 1440x2392.
This corresponds to the screen resolution, without the navigation bar.
Therefore, you'll end up with a small (but noticable) letter box effect. 😞

The solution would be to use the WindowManager service and the getRealMetrics method:

WindowManager wm = (WindowManager) context.getSystemService(WINDOW_SERVICE);
Display display = wm.getDefaultDisplay();
DisplayMetrics metrics = new DisplayMetrics();
display.getRealMetrics(metrics);

😃

This is already possible using the System UI Tuner but maybe it can be done programmatically.

Every time a recording is stopped, a number of DeadObjectExceptions are written to logcat. The number of these is ever-increasing (until next reboot). It increments each time Telecine (or any other app using MediaProjection) is launched (killed?). Now, maybe this can simply be ignored. But, having, sometimes, hundreds of these messages written each time the recording is stopped, is rather annoying at least.

See here: https://code.google.com/p/android/issues/detail?id=81152

Confirmed on 5.1.1 (Nexus 5)

Any ideas on how to work around this?

05-23 12:46:16.623 725-725/? W/MediaProjectionManagerService﹕ Failed to notify media projection has stopped
android.os.DeadObjectException
at android.os.BinderProxy.transactNative(Native Method)
at android.os.BinderProxy.transact(Binder.java:496)
at android.media.projection.IMediaProjectionCallback$Stub$Proxy.onStop(IMediaProjectionCallback.java:75)
at com.android.server.media.projection.MediaProjectionManagerService$ClientStopCallback.run(MediaProjectionManagerService.java:614)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at com.android.server.SystemServer.run(SystemServer.java:269)
at com.android.server.SystemServer.main(SystemServer.java:170)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)