joshthederf / ldrparser Goto Github PK

Noticed this while reading the code trying to comment it.

Lines 128-136 checks if the part has been cached. If it hasn't, it reads and caches it. But what happens if it is cached? That condition is not handled. Instead, it simply returns the myDef object constructed above which does not appear to be all the information needed.

Now, maybe I'm missing something, but it seems as if we only build the cache and never access it. In that case, it looks like the case needs to be handled and assign some key of myDef (sorry, can't figure out which) to self.__parts[myDef["partId"]] to take advantage of the cache.

How were you planning on handling comment parsing? What all do you want to do with them, what should be filtered out, and how should they be stored?

Hello. I'm Minwoo Shin.

I would like to read the flight log of the DJI L1 as a "*.LDR" file that directly stores LiDAR data.

I wonder if this repository supports reading DJI's files.
It looks like it converts it to a JSON file containing a 3D coordinate system, but is this code that can read DJI's ".LDR" file?

You don't need semicolons at all. ;)

Wow man, this is nice! 😄 I see some things that could be improved, but overall good job! Honestly, when I get some extra time I will have to contribute back to this. And who knows, maybe I can base the next version of the importer script on this!

Both the unofficial and p folders have these.

• Programmatic flags
• Command-line flags

Opening as a reminder issue.

LSynth is rather popular and should be supported.

• Programmatic flag
• Command-line flag

Opening as a reminder issue.

Hey!

I am wanting to resume some work on the importer script during the next few weeks, and you know just as well as I do that eventually we will need to completely replace that script because of all the issues it has. I have two ideas for accomplishing that, and one of them involves this script here.

Basically, we would use this script for parsing it and my script would simply convert the data generated by this into mesh. Your script would remain over here, and mine over there. This would make maintenance and releases much easier, as if there were changes made over here, I would simply need to update mine with the latest version and release.

I am wondering what the current state of this script is, if it is in a good state that I could begin integrating it into my script, and if there is anything I can do to help improve this script further.

I really would like to pursue this idea, as I like it more than the alternative, rewriting everything on my side.

Thanks!