[C++ Language] JSBSim defaults to C++11 about jsbsim HOT 12 CLOSED

That's an interesting option. I am not familiar with all the goodies brought by the last revisions of the C++ standard but there are a couple of interesting features in C++11:

• constexpr
• The type inference auto
• The range based for loops

👍 to that proposal.

from jsbsim.

@bcoconni I like those new features as well as the std::unique_ptr and lambda functions. See for example here, here, here, or here.

My proposal: From now on switch to C++11, whether we are reviewing old code or we are adding new features to the library.

from jsbsim.

Since we are embedding the code of JSBSim in FlightGear and since they are using C++11, I suggest we do not use features of C++ earlier than C++11.

from jsbsim.

@bcoconni I presume you meant to write not later than C++11 (from 2011), i.e. don't use any features in C++14 or C++17?

from jsbsim.

@seanmcleod
Ooops ! Yes you are right, I meant later 😄

from jsbsim.

I propose this additional configuration in src/CMakeLists.txt

if(NOT CMAKE_VERSION VERSION_LESS 3.1)
    set(CMAKE_CXX_STANDARD 11)
else()
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
endif()

from jsbsim.

@agodemar Is the flag -std=c++11 recognized by all compilers (Visual C++, gcc and clang) ?

from jsbsim.

• Visual C++: The compiler does not offer a specific C++11 mode and defaults to C++14, but that standard is fully inclusive of C++11.
• g++: yes
• clang: yes

from jsbsim.

Thanks.

So I guess Visual C++ will complain if we provide it with the flag -std=c++11 ? Which means that the code should be something like below (swapping the two if branches to save the negation NOT on the CMake version condition) ?

if (CMAKE_VERSION VERSION_LESS 3.1)
  if (NOT MSVC)
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
  endif()
else()
  set(CMAKE_CXX_STANDARD 11)
endif()

from jsbsim.

It should work.

There is no C++11 flag for Visual C++. For later versions of the standard the flags are: /std:c++14 and /std:c++17 (or /std:c++latest).

from jsbsim.

@agodemar
Will you push that change to master ? I suggest that you skip the pull request process and push directly to JSBSim:master

from jsbsim.

I've changed the title of this issue, which is now closed.

from jsbsim.