Comments (4)
I'm a little bit confused. While trusting those headers is bad, bidi acts as a whitelist system, and that effectively prevents this doesn't it?
from bidi.
I think I see the problem. Bidi has its own concept of what the actual host is, and you're reading the host header directly elsewhere in your application (for what?) and that could be set to evil.com.
from bidi.
I was using yada.context/url-for
to create a URL for a link. They are internal links, so I could just as easily have used path-for
.
I'm using :*
as the host as I had issues with specifying it explicitly (don't remember what now). If the :host
was specified in the vhosts-model
, would that avoid the issues here?
from bidi.
Ah, I hadn't considered those functionalities together. I don't think :*
is very safe then. Specifying a host should alleviate this.
from bidi.
Related Issues (20)
- Bidi brings older version of `ring-core` into projects; should it be :scope "provided"? HOT 1
- `just-path` removes # HOT 9
- Ring async handler support HOT 1
- Coercion around a route causes custom match extension records to be lost (affects vhosts) HOT 1
- Add Ataraxy in the comparison chart in the README.md
- compilation warnings (from a shadow-cljs project depending on [bidi "2.1.4"]) HOT 3
- Document uri-info better
- bidi.ring - alternates don't work
- Example with alpeh
- CLJS implementation does not parse longs properly
- Feature Request: Adding headers in a 307 redirect.
- Implementation of protocols for MultiFn HOT 2
- How to route to a pdf file
- Non-ASCII characters as path parameters
- Reflection warning on java.net.URLDecoder/decode
- resourcesMaybe no caching HOT 1
- filesmaybe missing
- Coercion on route path and query paramaters HOT 1
- Don't remove :handler from match-context
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bidi.