Giter VIP home page Giter VIP logo

Comments (1)

griff avatar griff commented on August 18, 2024

Most of my reasoning for making the Schema more strict is explained here #130 but in essence bidi/Pattern is implemented for all maps, sets and vectors and therefore when the schema contains (s/protocol bidi/Pattern) it will accept ANY map, set or vector regardless of whether they are valid bidi patterns or not making the schema pretty useless as a validator.

My original PR was meant to start a discussion about what a valid bidi pattern is and how to validate that. For instance custom pattern matchers are not part of the BNF for bidi patterns as they are described in the README but they clearly should be. One way to support custom pattern matchers while still leaving the schema strict is to have separate protocols for internal and custom pattern matchers so either saying bidi/Pattern is an internal protocol and custom pattern matchers should instead implement a new bidi/PatternExtension protocol or renaming the current bidi/Pattern to bidi/InternalPattern everywhere and having a bidi/Pattern protocol for custom pattern matchers.

from bidi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.