Do not use applicaiton's alloc in layer about vulkan-extensionlayer HOT 8 CLOSED

That does sound like a loader issue.

There is a number of reason this kind of issue could happen in the layer (we could fail the allocation of a fence/semaphore implementing a timeline semaphore), so if the loader can't deal with that it sounds we're having an issue to implement creating internal objects to the layer.

from vulkan-extensionlayer.

Yes. I searched on Vulkan-ValidationLayers and https://github.com/baldurk/sample_layer.git , didn't find any layer is using the application's allocation.

from vulkan-extensionlayer.

I'm not sure if it is by design?

from vulkan-extensionlayer.

I'll investigate and maybe raise an issue with the loader.

The issue seems to be broader than just the allocation functions.

Let's say in timeline_CreateDevice you first create the device then create another object from the implementation like a command buffer. What are our options if the command buffer creation fails?

I think we would be in the same situation.

Maybe we're missing a handshake somewhere with the loader...

from vulkan-extensionlayer.

Ok, please try with CTS 1.2 (./deqp-vk -n dEQP-VK.api.object_management.alloc_callback_fail.device), a double free issue is raised.

from vulkan-extensionlayer.

Hi @djdeath , do you have time to look into this issue? Once this is resolved, timeline_sempahore layer is supposed to pass CTS 1.2 now.

from vulkan-extensionlayer.

Sorry for the late answer, I just filed KhronosGroup/Vulkan-Loader#339

from vulkan-extensionlayer.

closing since this appears to have been fixed by the loader.

from vulkan-extensionlayer.