[FEATURE] Events pattern. about wisper HOT 9 CLOSED

How about on accepts a regex?

Wisper.add_listener(ItemListener.new, on: /item_*_rs/, with: :add_item)

from wisper.

Makes more sense @krisleech.

from wisper.

@apotema can you try #80 please?

gem 'wisper', github: 'krisleech/wisper', branch: 'add-regex-support-for-on-arg'

from wisper.

By the way I don't think /item_*_rs/ is the correct regexp to match your events: http://rubular.com/r/2farGcgXD0

from wisper.

@krisleech the regex-support is working, all my 22 tests passed.

One thing that I noticed, is that all methods on the Listener stop working, once you set the 'on' condition.

This is my listener

class ItemListener
  def add_item user, models
    ItemService.new(user, models).save
  end
end

It works great if I call him like this.

Wisper.subscribe(ItemListener.new, on: /item_(.*)(add|query)_rs/, with: :add_item)

But if I require that Listener to respond to another call, like 'item_remove_rs', I can't put another function in there, and expect that it will respond to it.

class ItemListener
  def add_item user, models
    ItemService.new(user, models).save
  end
  def item_remove_rs user,models
    ItemService.new(user, models).save
  end
end

I have to subscribe this listener twice.

Wisper.subscribe(ItemListener.new, on: /item_(.*)(add|query)_rs/, with: :add_item)
Wisper.subscribe(ItemListener.new)

Now it will respond for my 'regex' and for the 'item_remove_rs'.

The 'on' parameter has the 'side effect' of making all the other methods on the listener inert.

Maybe we could think the 'on' parameter, not as something that will exclude other methods on the listener, but give a specific method a rule and let the other methods works a usual.

from wisper.

One thing that I noticed, is that all methods on the Listener stop working, once you set the 'on' condition.

Correct, the on option is used to restrict which events are broadcast to the subscribers. When used in conjuction with the with option this restriction remains.

You could indeed subscribe the listener twice, but I suspect you will end up with some events being broadcast twice also.

Maybe we could think the 'on' parameter, not as something that will exclude other methods on the listener, but give a specific method a rule and let the other methods works a usual.

At this stage I can't change the behaviour of these options.

What you might consider doing in your listener is just aliasing the methods:

class ItemListener
  def add_item
    # ...
  end

  alias_method :add_item, :item_query_rs
  alias_method :add_item, :item_discount_add_rs
  # etc...
end

from wisper.

@apotema Any further thoughts on this? I'd like to merge the PR.

from wisper.

No @krisleech. That is it for me.

Thanks

from wisper.

Thanks, PR merged. @apotema if you ever fancy blogging about how you are using eventing or even posting a gist or example to the Wiki I would be very intrested to take a look.

from wisper.