Giter VIP home page Giter VIP logo

Comments (6)

kunicmarko20 avatar kunicmarko20 commented on July 1, 2024 1

cc @greg0ire @OskarStark @core23 anyone remembers?

from sonataautoconfigurebundle.

kunicmarko20 avatar kunicmarko20 commented on July 1, 2024

Strange thing is that https://github.com/sonata-project/SonataAdminBundle/blob/3.x/src/Admin/AbstractAdmin.php#L1212 isn't deprecated 🤔 why is the get deprecated then, it could still delegate to registry

from sonataautoconfigurebundle.

gremo avatar gremo commented on July 1, 2024

@kunicmarko20 I think setTemplates will not be (It's the way to set templates, that will call TemplateRegistry). But when reading, we should use TemplateRegistry instead.

from sonataautoconfigurebundle.

kunicmarko20 avatar kunicmarko20 commented on July 1, 2024

Seems strange, that setter is still there but getter isn't. I would rather see both there or none.

from sonataautoconfigurebundle.

greg0ire avatar greg0ire commented on July 1, 2024

I don't remember, sorry… @TimoBakx, maybe you do?

from sonataautoconfigurebundle.

TimoBakx avatar TimoBakx commented on July 1, 2024

@greg0ire I think there were some users that depended on that method for their system to work and made us revert that specific deprecation.

from sonataautoconfigurebundle.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.