Autoconfiguration of Extensions about sonataautoconfigurebundle HOT 8 CLOSED

LOL, you right, I added that line 👍

from sonataautoconfigurebundle.

https://github.com/kunicmarko20/SonataAutoConfigureBundle/releases/tag/0.6.0

from sonataautoconfigurebundle.

I disagree. I think that this is out of the scope of the bundle (guessing, making it global if no targets, etc.). IMHO we just need to "replicate" the behavior of the tag, with global and target attributes.

The target attribute of the tag seems wrong to me (but this is a SonataAdmin fault, of course) because most of the time, you'll use the configuration:

sonata_admin:
    extensions:
        app.publish.extension:
            admins:
                - app.admin.article
            implements:
                - App\Publish\PublishStatusInterface
            excludes:
                - app.admin.blog
                - app.admin.news
            extends:
                - App\Document\Blog
            instanceof:
                -  App\Document\Page
            uses:
                -  App\Trait\Timestampable

Mixing both target attribute and configuration will lead to a mess.

It is fine, as you say, to "guess" for entity and controller of an admin, but for extensions it seems wrong to me.

from sonataautoconfigurebundle.

I don't see a value in admin extension class that requires you to have annotation, then you can just register it as a service, it is not autoconfigured either way.

from sonataautoconfigurebundle.

I don't see a value in admin extension class that requires you to have annotation, then you can just register it as a service, it is not autoconfigured either way.

The annotation is only needed to make it global (and maybe configure the target), without repeating the service, as explained here #15

from sonataautoconfigurebundle.

Hm, ok, I can see the value in that, btw:

App\Admin\Extension\:
    resource: '../../src/Admin/Extension'
    tags: [{ name: 'sonata.admin.extension' }]

This is not needed anymore.

from sonataautoconfigurebundle.

This is not needed anymore.

Really? Why is not needed? The compiler pass do its stuff for services tagged with sonata.admin.extension: who is adding this tag? I think this code:

App\Admin\Extension\:
    resource: '../../src/Admin/Extension'
    tags: [{ name: 'sonata.admin.extension' }]

from sonataautoconfigurebundle.

https://github.com/kunicmarko20/SonataAutoConfigureBundle/blob/master/src/DependencyInjection/SonataAutoConfigureExtension.php#L47

from sonataautoconfigurebundle.