Default value for mosaic button about sonataautoconfigurebundle HOT 6 CLOSED

0.x allows BC Breaks, and it's not a big change, so let's just add it, we did it already with a different config.

from sonataautoconfigurebundle.

But you should ofc mention it somewhere

from sonataautoconfigurebundle.

Hi @jgrygierek, you are correct. I am away until Wednesday, would you be able to provide a PR? or maybe @gremo . I am able to merge it over my phone.

from sonataautoconfigurebundle.

Mosaic button can be globally enable/disable for all admins (SonataAdminBundle configuration). Once you disable for all admin, you need to disable it for each admin... using the annotation, because default value is true.

As I said in a previous issue, in the AdminOptions.php class, all boolean variables should be NULL by default. This way, not providing defaults, will solve the issue.

This should be fixed in 1.x

from sonataautoconfigurebundle.

And I thought that was the issue since the default value is true. I guess it is time to remove default values, @gremo are you able to do it?

from sonataautoconfigurebundle.

Yes, but this would be a BC break, so... maybe 1.0?

from sonataautoconfigurebundle.