kyoripowered / adventure-text-feature-pagination Goto Github PK

This may be a mistake on my end, attempting to integrate this API with my recent works and having some difficulty with pagination. No matter what I attempt to do, the footer is always slightly longer than the header. I've attempted at this point any number of fixes and tried digging for some potential solutions.

I do know this is still a very new feature, so I figured I'd at least provide a bug report for my findings to see if it helps

Version: 3.0.2

Using text-serializer-gson,text-feature-pagination, and text-api with text-bukkit-adapter

Platform is Paper

Width: 53

Width: 50

With longer title, width 50

Width 50 with dummy data to cause pagination

smol title

Code (In Kotlin) ((An abomination of formatting, I apologize in advance))

return Pagination.builder().line { cs ->
            cs.character('=')
        }.width(53).build(TextComponent.of("Charters").color(TextColor.GOLD), Pagination.Renderer.RowRenderer { value, index ->
            return@RowRenderer listOf(if (value == null) TextComponent.of("${index + 1}. ").color(TextColor.YELLOW).content("ERR?").color(TextColor.RED) else
                TextComponent.of("${index + 1}. ")
                        .color(TextColor.YELLOW)
                        .append(TextComponent.of(value.name).color(TextColor.GRAY))
                        .hoverEvent(HoverEvent.of(HoverEvent.Action.SHOW_TEXT, TextComponent.of("Click to view this charter").color(TextColor.GRAY)))
                        .clickEvent(ClickEvent.of(ClickEvent.Action.RUN_COMMAND, "/charter info ${value.name}")))
        }, Pagination.PageCommandFunction { page -> "/charter list -page $page" })

        val rendered = settlementService.buildSettlementPagination().render(settlementService.dummyData().sortedBy { settlement -> settlement.name }, page)
        rendered.forEach { comp ->
            TextAdapter.sendComponent(p, comp)
        }

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): Update dependency com.google.guava:guava-testlib to v33.2.1-jre
• chore(deps): Update dependency net.kyori:adventure-api to v4.17.0
• chore(deps): Update gradle and github actions (gradle, io.github.gradle-nexus.publish-plugin)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

It would be great if we could render the footer in a similar way to the header - that is have renderFooter (and maybe renderFooterButtons) be in the Pagination.Renderer Interface instead of the PaginationImpl class. This would allow for arranging the previous and next buttons in a desired way among other custom formatting

Hello, I'm wondering if it's under consideration to publish a release version soon. Is there anything preventing a full release?