SearchResult no longer ordered chronologically, it could break user expectation about lightkurve HOT 4 OPEN

@christinahedges The sort order change was slipped in in PR #1380 . I wonder if the change could break other people's codes (in addition to mine).

My actual use case is to download the lightcurves of a given TIC for all observation time, with the best available product/author for each sector (use case in #1048).

The change makes the resulting SearchResult / correspond LightCurveCollection no longer orders chronologically. I have to explicitly re-sort the SearchResult to compensate it.

from lightkurve.

I'm experiencing the same and it is breaking my code too.

from lightkurve.

@orionlee so MAST uploaded a few new HLSPs that broke other stuff in lightkurve and this was my attempt at fixing it. I'm working on 2.5.0dev right now with a much better fix.

Let me take a crack at finishing this up and let's chat on that PR about what to do with v2.4.2 and find the best solution

from lightkurve.

christinahedges: I have subscribed to PR #1383 for the new new HLSPs. Ping me when you're ready.

In the meantime, I use a helper to resort the SearchResult chronologically in my codes.

import lightkurve as lk

def _sort_chronologically(sr: lk.SearchResult):
    res = lk.SearchResult(sr.table.copy())
    res.table.sort(["distance", "year", "mission", "sort_order", "exptime"])
    return res

from lightkurve.