[BUG] Invalid variant: OperatingSystem about macchina HOT 10 CLOSED

OperatingSystem is a actually an invalid readout on Linux systems.

I haven't touched the codebase in very long, did macchina previously allow passing invalid readouts?

from macchina.

I haven't touched the codebase in very long, did macchina previously allow passing invalid readouts?

I don't know. This is the first time I've used macchina, and all I know is the error message I obtain from it when run on my system.

from macchina.

Linux users should not use the OperatingSystem as it is reserved for the BSDs (including macOS) and Windows. Instead, they should be using Distribution.

EDIT: It wouldn't make a lot of sense to implement both readouts on the same system, as they both represent the same thing in the Linux world.

from macchina.

Please feel free to close this issue if you don't feel it's relevant.

from macchina.

Was the answer helpful in resolving your issue?

from macchina.

I didn't fully read the backtrace you provided, the message "Invalid variant: OperatingSystem" made me assume that you passed -o OperatingSystem to macchina, even though you explicitly listed just the command macchina in the second step. My bad.

I can reproduce the panic on my end, I'll investigate the issue. It's most likely got to do with our recent upgrade from clap@v3 to clap@v4.

from macchina.

First time using the app and i have almost the same issue on Windows

macchina                                                                                                                                    
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "Invalid variant: OperatingSystem"', src\data\mod.rs:142:61
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

from macchina.

Can you please build from source and confirm that 8abf983 fixes the issue?

from macchina.

Can you please build from source and confirm that 8abf983 fixes the issue?

Yes, that fixes it. Thank you.

from macchina.

Good to hear!

EDIT: The new version has been released.

from macchina.