Giter VIP home page Giter VIP logo

Comments (4)

macisamuele avatar macisamuele commented on May 20, 2024 1

Sorry, I might have missed the detail that your local-formatter is not a local-run of the pre-commit hook.

What I would deduce is that the two pre-commit hooks are attempting to enforce different styles.

I think that if the tool were to expose --offset configuration you could be able to achieve "equal formatting".
Going to be implementing it in #143

from language-formatters-pre-commit-hooks.

macisamuele avatar macisamuele commented on May 20, 2024

Most probably the discrepancy is caused by the fact that pre-commit hooks create the python virtual environment with all the required dependencies on their first run, after that the virtual environment is just reused and not recreated.
The same applies on the CI, with the only difference that the environment is always clean, hence the new version of the direct and indirect dependencies are fetched.

Are you able to reproduce the same issue after running pre-commit clean and then running the pre-commit hooks again?

from language-formatters-pre-commit-hooks.

hdadhich01 avatar hdadhich01 commented on May 20, 2024

Yes, seems to perform the same despite cleaning the hook environments.

from language-formatters-pre-commit-hooks.

hdadhich01 avatar hdadhich01 commented on May 20, 2024

Great, thanks! Could you put out a release tag sometime soon?

from language-formatters-pre-commit-hooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.