Giter VIP home page Giter VIP logo

optimism-dai-bridge's Issues

Implementation wrong in some lines of code

For example , in contracts/L2/L2DAITokenBridge.sol

there is

_initiateWithdrawal(msg.sender, msg.sender, _amount, _l1Gas, _data); 

which should be

_initiateWithdrawal(msg.sender, msg.value ,  _amount, _l1Gas, _data);  

Since the second argument is amount , it should be msg.value

L2 Dai is not censorship-resistant

In the L2 Dai implementation, governance has the ability to burn Dai in any address.

This enables Dai censorship of a user's wallet by governance, which means that we can't make the claim that L2 Dai is censorship-resistant as it is on L1.

This needs a broad team, and potentially MKR holder, discussion.

if (from != msg.sender && wards[msg.sender] != 1) {

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.