marcuswolschon / osmeditor4android Goto Github PK

I don't want to upload all tracks to OSM, instead I want to save some of
them as GPX files so they can be loaded using e.g. JOSM. The attached patch
does that.

BTW, the "Upload GPS Track" menu item is greyed out and doesn't seem to do
anything - it should probably be removed so it doesn't confuse users.

I can't to run application with Russian locale. When I change locale to English 
all fine.

currentLocationRadioButton.setText(getResources().getString(R.string.location_cu
rrent_text) + " Lat "
                        + lat + ", Lon " + lon + metaData);


should be changed to

currentLocationRadioButton.setText(getResources().getString(R.string.location_cu
rrent_text, lat, lon, metaData)
and metadata be localized too.

"Accuray: " was neither translated, not did it provide unit for the given 
number (meters in Android) 


A patch is attached.

The location picker does not allow entering negative lat/long values, which 
makes it impossible to enter an area west of Greenwich or south of the 
equator.
It is easy to fix: just add the 'signed' property to the xml.
Patch is attached.

Ludwig Brinckmann

What steps will reproduce the problem?
1. Open the tag editor and try to type something.
2. You need about a half a second to type a single letter.
the gui responds extreme sluggish.


What version of the product are you using? On what operating system?
Motorola Milestone with 2.1 Firmware

All classes and at least the most important methods need to be commented.

What steps will reproduce the problem?
1. Load data
2. Make mistake or decide change isn't needed or that you have loaded too large 
an area
3. ??? Be confused. Even killing app or restarting phone doesn't help.

What is the expected output? What do you see instead?
I expect to be able to clear loaded data without saving or uploading from the 
menu. 
Instead I can find no such option.

What version of the product are you using? On what operating system?
V.0.6.2 on Android 1.5 HTC Hero.

Please provide any additional information below.
Keep up the good work guys this app is important for OSM. 

Android has inputfields with build-in auto-completition feature. The
easiest way to help the user while writing tags is to have a list of all
(or the most common) tags and to insert them in this feature.

What steps will reproduce the problem?
1. Download app from Market/install from .apk/run from trunk via Eclipse
2. Start app

What is the expected output? What do you see instead?
Message shows: The application [...] has stopped unexpectedly. Please try 
again.

What version of the product are you using? On what operating system?
Android 1.51 JF on G1
Android 1.5 official on Magic

Please provide any additional information below.
It seems that the strings.xml from res/values is used and not a language 
specific version. The string ids are wrong when he tries to create the 
dialogs in:
Main.onCreate()
DialogFactory.DialogFactory(){
  [..]
  noLoginDataSet = createBasicDialog() // wrong parameters are passed 
since the ids do not match the ones on the device
  [..]
}
DialogFactory.createBasicDialog(){
  [..]
  dialog.setTitle(titleId); // crash !!!
  [..]
}

Hi,

when there are no translation for current Android locale settings,
application crash at startup.

What steps will reproduce the problem?
Zoom in,Zoom out, other operations


On the Freerunner I have to click the Menu button, go to More, click on the
keyboard, click to change the type of keyboard, and then click vol+ or vol-  
Also, the onscreen keyboard takes have the screen and I do not want to
close it since I have to do the steps above again.


What is the expected output? What do you see instead?
For some commands it is difficult to use Vespucci without a hard keyboard. 

A onscreen interface could be useful for people with phones which do not
have hard keyboards.


What version of the product are you using? On what operating system?

Vespucci 0.6 on Neo Freerunner with Koolu 7

We need a undo (and therefore a history-) functionality.

Hi. I've uploaded a germany translation in r66. Please verify somebody with
a german translation on a real device...

Display a compass to the user. Optionally, he can let rotate the map
according to the current direction.

Until now, username (String) and timestamp (Date) get parsed and saved. I
don't think we need them, so we can delete them.

The main reason to do this is to speed up the serialization process.

The G1/ADP1 GPS-Signal provides an accuracy-value, which will be displayed
as half-transparent circle around the given position. I've never verified
the correctness of the display, so I've to assume, it's incorrect...

We should download and show the tiles in the background to make
navigating the map to the area you want to edit easier and
to show if there is any need to add things to the map at all.

Reminder for myself to set OSM-Server to the public one

A simple patch to add an "OK" button to the tag editor. Using the touch
screen is easier than using real buttons IMHO, so everything should be
accessible just via touch screen.

Automaticly download the area next to the view. 

This depends on:
 * an optimized drawing (more data = more drawing = slower)
 * intelligent synchronization between current- and api-storage

Future request:

It would be very useful to download all my traces from OSM to this
application. So that I can see what areas are already traced.

(Not a bug, just a documentation request)

As a user, I really need a tutorial for Vespucci.
I guess it would make new users' life much easier.

I have spent a lot of time trying to understand Vespucci, but I am still 
very hesitant and not productive, I often get "Force close" messages, 
probably because I click something when I am supposed to click something 
else. I sometimes have to reboot the phone just to get Vespucci into a 
stable state. I would like to map a lot, but I only managed to send a few 
new streets so far.

Could we have a tutorial that explains step-by-step how to:
- See which streets are already mapped around me.
- Get the GPS trace for a street I walk along.
- Draw the street.
- Send it to the OSM server.

Thank you very much!
If I had access to the Wiki, I would be happy to start writing this howto.

What steps will reproduce the problem?
1.  Set Vespucci collecting a GPS trace
2.  Press the Back button on the phone
3.  Re-start vespucci.

What is the expected output? What do you see instead?
The program should store the GPX trace so that it is visible when the
program is re-started.
Instead, Vespucci exits without confirmation, and does not re-display the
GPX trace when it is re-started.

What version of the product are you using? On what operating system?
0.6.1 - Android 1.5.

Please provide any additional information below.

Tell the user who to zoom (volume up/down or lens/shift). If somebody knows
a better way, we could post a toast on the first startup.

It would be helpful to get a list of changes before the upload, similar to
what JOSM does.

What steps will reproduce the problem?
1. Search Marketplace for Vespucci
2. Request for its installation
3. Warning appears in notifications, clicking on it displays "Installation
Error: Package file was not signed correctly." [OK]

What is the expected output? What do you see instead?

Expected output: Installation succesful
Instead: error as indicated above

What version of the product are you using? On what operating system?
0Attempting to install 0.6 on Android 1.5 (Rogers HTC Dream)

Hi,
i completed the italian translation of this nice app.

I attach here the file with Market description hoping that can be useful
for other guys.

Bye,
Diego Pierotto

What steps will reproduce the problem?
1. Load data
2. Make mistake or decide change isn't needed or that you have loaded too large 
an area
3. ??? Be confused. Even killing app or restarting phone doesn't help.

What is the expected output? What do you see instead?
I expect to be able to clear loaded data without saving or uploading from the 
menu. 
Instead I can find no such option.

What version of the product are you using? On what operating system?
V.0.6.2 on Android 1.5 HTC Hero.

Please provide any additional information below.
Keep up the good work guys this app is important for OSM. 

On March 22/23 the new API will be released. We have to check and update
the paths and maybe some logic...

We should use the full class names as tags, to make filtering logcat for this 
one application possible.
(I already implemented this here)

The user should be able to split ways. By clicking on a way, this way gets
splitted into two ways. By clicking on a node used by two ways, every way
should get its own node. 

All new created nodes should not lay above the old one, but next to it.

What steps will reproduce the problem?
1. Get a GPS fix
2. Go to "Transfer.."
3. Select "Download area"


What is the expected output? 
Something to get downloaded ? I never managed to get it to work

What do you see instead?

"Something strange happened, would you like to send and email ?"

and "Loading data into memory..." indefinitely

What version of the product are you using? On what operating system?
0.5.2 on a Neo Freerunner GTA02 with Koolu beta 7

Please provide any additional information below.
Same thing happens on Koolu beta 6

Clean instalation of Vespucci 0.6.1 onto ADP1 running CyanogenMod 4.0.4
force closes on start.

(This is a preliminary description. I still need to find the exact steps to
reproduce it reliably.)

When you create new elements and then exit Vespucci with the home button
and then return it can happen, that soem of the elements are lost.

Also in this context: When repeatedly exiting and restarting then old
versions of the storage database seems to be kept und switched through them
when pressing the back button in Vespucci.

No matter which mode one is in, a long click could open the "edit tags"
view. This saves clicks if you want to edit tags but you're not in the
"edit tags" mode: 1 long click vs. menu, edit tags, click, menu, change to
old mode

When the user selects multiple elements, he should be asked which one he
wants to select. Until now, it's random :-(

Show: road, rivers, POI, and all other visible things
Hide: city borders, and anything not visible to the human eye

On my mapping walk today, I got really confused by what appeared to be a 
badly mapped road. When I came back home and checked OSM, I realized it was 
an administrative border division.

This non-physical border was off 20 meters from a real road, so I began 
suspecting my GPS, and made node connection mistakes.

I am probably not the only one to waste resources and pollute OSM's data 
because of this. To prevent further damage and more productive work, I 
suggest not showing nodes and lines that are not physical.

I am not sure if you are familiar with the OpenMoko phone. It is an open 
source phone which can run Android. However, while the OpenMoko has a 
touch-screen it does not have as many buttons as the G-Phone.

I installed the app on OpenMoko and it runs and can download and display 
data, however I cannot edit it as I am required to zoom in for editing. For 
the zoom you apparently use the volume control that OpenMoko does not have. 

Would that be possible to add on-screen controls for zooming (and other 
parts of functionality)?

A few suggestions for improving the User Interface:
* Ask for confirmation when Exiting the program with the back button.
* Provide on-screen Toggle buttons to:
     - Switch on and off GPX track recording.
     - Toggle following of GPX trace (when following, OSM data should be
downloaded automatically as the position changes).
     - Change Mode - pressing this button displays a mode selecting dialog.

There will probably be more.

I will have a quick go at implementing these to see how it affects usability.

Via Errormailer:
I had moved the screen to the left (downloaded data was on the right), then
chose to download some more, which prompeted the error below:

de.blau.android.exception.OsmServerException: The API server does not
except the request:
org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnection:http://
api.openstreetmap.org/api/0.5/map?bbox=-0.1117744,51.5198007,-0.0998428,51.53583
38

Path orientation (show with arros in JOSM) is precisous for one way roads
or for roundabouts...
it would be nice to have a mean to show and change path orientation...

I've fixed the orientation to landscape. A orientation change would force
Android to kill and restart the whole application and the whole memory must
be refilled. Additionally, a previous opened alert dialog can't be closed
from the new called application...

There is a fix for this problem, described here:
http://android-developers.blogspot.com/2009/02/faster-screen-orientation-change.
html

Probably by painting on a bitmap, that gets moved and only redraw, when the
user edited something...

Tried to install 0.6.1 from Android marketplace, but got the error 'package
not signed correctly'.

Looked a bit boring to me.

Have attached a patch for it but I'm going to be re-factoring it so it can
deal with waterways/railways etc without hundreds of variables. But this
shows initial process, and looks very pretty!

I translated Vespucci into Hungarian, and attached the file to this issue.

Matthias already mentioned he wants a more generic solution, but I'm
attaching this patch anyway so it doesn't get lost: this helps you add
housenumbers by offering a "Set housenumber" button and showing a number pad.

Hi,

I attach Czech translation (cs_CZ) for osmeditor4android.
Thanks for checking.

I got the "something strange happened" error when downloading the current
view. I think this happens if the area is quite large and in a city, i.e.
if there are many nodes and the timeout of 10 seconds is not enough.

The error was this:

de.blau.android.exception.OsmServerException: The API server does not
except the request:
org.apache.harmony.luni.internal.net.www.protocol.http.HttpURLConnection:http://
api.openstreetmap.org/api/0.5/map?bbox=13.394992,52.5127342,13.4120344,52.535620
6

I checked the value of con.getResponseCode() and it was -1. I don't know
how to solve this (except by increasing the timeout), but the error message
should probably be more verbose and mention the timeout if
con.getResponseCode() == -1.

JOSM has the validator plugin which can warn about errors and other issues
with meta data and real data for that matter like unjoined ways etc.

It would be nice to see unnamed highways at least highlighted some how to
make it easier to work out which ways need to be named.