Giter VIP home page Giter VIP logo

Comments (5)

cjmartian avatar cjmartian commented on August 10, 2024

Hey @hanzei,

I'd like to take this one.

If I'm understanding this correctly, you want this plugin to run if an E20 license is enabled or if the config states it is being ran in development mode?

I'm looking at mattermost/mattermost-plugin-api#72 and it seems like the function that is currently being called does just that.
https://github.com/mattermost/mattermost-plugin-api/pull/72/files#diff-db2f4f67c054c0fe58427305559af1f5R21-R42

I think I'm missing something perhaps, let me know!

from mattermost-plugin-msteams-meetings.

hanzei avatar hanzei commented on August 10, 2024

Exactly @cjmartian. mattermost/mattermost-plugin-api#72 is just a library function. This ticket is about adopting the library function for this PR.

Does this make the ticket more clear?

from mattermost-plugin-msteams-meetings.

cjmartian avatar cjmartian commented on August 10, 2024

I believe so @hanzei I'll set up a dev environment and see if I can't add these changes. If I have more questions, would you mind if I ping you again here?

Thank you for the explanation

from mattermost-plugin-msteams-meetings.

hanzei avatar hanzei commented on August 10, 2024

Sure, ping me 👍 Also feel free to PM me on the Mattermost Community Server.

from mattermost-plugin-msteams-meetings.

hanzei avatar hanzei commented on August 10, 2024

If you found this ticket interesting, you might also want to take a look at mattermost/mattermost-plugin-mscalendar#194

from mattermost-plugin-msteams-meetings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.