Comments (5)
Hey @hanzei,
I'd like to take this one.
If I'm understanding this correctly, you want this plugin to run if an E20 license is enabled or if the config states it is being ran in development mode?
I'm looking at mattermost/mattermost-plugin-api#72 and it seems like the function that is currently being called does just that.
https://github.com/mattermost/mattermost-plugin-api/pull/72/files#diff-db2f4f67c054c0fe58427305559af1f5R21-R42
I think I'm missing something perhaps, let me know!
from mattermost-plugin-msteams-meetings.
Exactly @cjmartian. mattermost/mattermost-plugin-api#72 is just a library function. This ticket is about adopting the library function for this PR.
Does this make the ticket more clear?
from mattermost-plugin-msteams-meetings.
I believe so @hanzei I'll set up a dev environment and see if I can't add these changes. If I have more questions, would you mind if I ping you again here?
Thank you for the explanation
from mattermost-plugin-msteams-meetings.
Sure, ping me 👍 Also feel free to PM me on the Mattermost Community Server.
from mattermost-plugin-msteams-meetings.
If you found this ticket interesting, you might also want to take a look at mattermost/mattermost-plugin-mscalendar#194
from mattermost-plugin-msteams-meetings.
Related Issues (20)
- Add warning when creating a meeting on channels HOT 5
- MS Teams call icon is only showing in the collapsed plugin list HOT 1
- MS Teams collision detection will throw an error if users mashes the Create New Meeting button
- Polish: Update Plugin configuration screen with some extra text and a link to documentation HOT 1
- Release v1.0.0 HOT 1
- Improve Installation & Configuration Docs HOT 2
- 400 on installing using binary HOT 4
- Add command autocomplete HOT 4
- Release v1.0.1
- Cross-plugin task: Enable the CircleCI "test" job in each plugin repo that has a webapp plugin
- Master branch is throwing an error on webapp plugin startup HOT 7
- 2nd time when user Disconnect the account then Validation Message Should be Proper. HOT 8
- There Should be a separate command for Connect. HOT 1
- slash Command improvement HOT 1
- in the desktop app msteem call UI is not same as Web-app UI. HOT 3
- MS Teams Calling shows plugin ID as App Bar tooltip HOT 2
- Intermittent issue where user see's an error and must click the connection link a 2nd time
- Release v2.1.0 HOT 3
- Installation docs still lists E20 license as a requirement HOT 2
- x509: certificate is not valid for any names, but wanted to match login.microsoftonline.com
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-msteams-meetings.