Comments (7)
@larkox or @hanzei do either of you know if this is in-fact an issue that must be addressed in each plugin repo individually?
As you can can see, 2 other plugins are also affected.
from mattermost-plugin-msteams-meetings.
I wonder if there has been any changes in the CSS. What I think is happening here is that SVGs are being treated different as font-icon in terms of spacing. Not 100% sure if where should we fix those.
from mattermost-plugin-msteams-meetings.
In order to have proper styling, the elements must have the "icon" class. We can solve this in two different ways:
- Set the icon class in each plugin, and any new plugin.
- Set the icon class at the parent element in the webapp code, and update the plugins that use the icon class already, so it is not applied twice.
Thoughts?
from mattermost-plugin-msteams-meetings.
Option 2. seems like the right way to me. Plugins shouldn't rely on some CSS class that the webapp uses.
from mattermost-plugin-msteams-meetings.
Agree with @hanzei that we would ideally not be brittle in depending on CSS classes, but I admit that ship has probably long since sailed. Can we do "both" somehow, by having the plugin conditionally add the icon
class if it intends to support older Mattermost server versions? It would be a shame for new versions of a plugin to appear broken for months until the changes in the webapp get into production.
from mattermost-plugin-msteams-meetings.
If we were to do both, we would have to change "all the plugins". Is it something we want to do?
For short term I will just add the icon class to MSTeams, and if we agree on a long term solution, we can file the needed tickets both in the main product and each of the plugins.
from mattermost-plugin-msteams-meetings.
@larkox, could we only change the plugins that "use the icon class already", as proposed in Option 2? Effectively allowing those plugins to continue to support older webapp versions than the one in which this class fix will ship?
from mattermost-plugin-msteams-meetings.
Related Issues (20)
- Add warning when creating a meeting on channels HOT 5
- MS Teams call icon is only showing in the collapsed plugin list HOT 1
- MS Teams collision detection will throw an error if users mashes the Create New Meeting button
- Polish: Update Plugin configuration screen with some extra text and a link to documentation HOT 1
- Release v1.0.0 HOT 1
- Improve Installation & Configuration Docs HOT 2
- 400 on installing using binary HOT 4
- Add command autocomplete HOT 4
- Release v1.0.1
- Cross-plugin task: Enable the CircleCI "test" job in each plugin repo that has a webapp plugin
- Master branch is throwing an error on webapp plugin startup HOT 7
- 2nd time when user Disconnect the account then Validation Message Should be Proper. HOT 8
- There Should be a separate command for Connect. HOT 1
- slash Command improvement HOT 1
- in the desktop app msteem call UI is not same as Web-app UI. HOT 5
- MS Teams Calling shows plugin ID as App Bar tooltip HOT 2
- Intermittent issue where user see's an error and must click the connection link a 2nd time
- Release v2.1.0 HOT 3
- Installation docs still lists E20 license as a requirement HOT 2
- x509: certificate is not valid for any names, but wanted to match login.microsoftonline.com HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mattermost-plugin-msteams-meetings.